diff --git a/pkg/log/pretty.go b/pkg/log/pretty.go index 50d537d..f2dd433 100644 --- a/pkg/log/pretty.go +++ b/pkg/log/pretty.go @@ -171,7 +171,7 @@ func (d *PrettyLogger) DebugLn(a ...interface{}) { } func (d *PrettyLogger) Success(l string) { - d.InfoFWithoutLn("🎉 %s", l) + d.InfoF("🎉 %s", l) } func (d *PrettyLogger) Fail(l string) { diff --git a/pkg/log/pretty_test.go b/pkg/log/pretty_test.go index dafcf7d..4804661 100644 --- a/pkg/log/pretty_test.go +++ b/pkg/log/pretty_test.go @@ -150,6 +150,20 @@ func TestPrettyDebugStream(t *testing.T) { }) } +func TestPrettySuccessNewLine(t *testing.T) { + outBuffer := &bytes.Buffer{} + debugBuffer := &bytes.Buffer{} + + pretty := NewPrettyLogger(LoggerOptions{ + IsDebug: false, + OutStream: outBuffer, + DebugStream: debugBuffer, + }) + pretty.Success("My Task") + + assertInBuffer(t, outBuffer, "My Task\n", true) +} + func TestPrettyFollowInterfaces(t *testing.T) { assertFollowAllInterfaces(t, NewPrettyLogger(LoggerOptions{IsDebug: true})) } diff --git a/pkg/retry/retry.go b/pkg/retry/retry.go index 7f4e15e..c5788cd 100644 --- a/pkg/retry/retry.go +++ b/pkg/retry/retry.go @@ -315,7 +315,7 @@ func (l *Loop) run(ctx context.Context, task func() error) error { // Run task and return if everything is ok. err = task() if err == nil { - l.logger.Success(l.prefix + "Succeeded!\n") + l.logger.Success(l.prefix + "Succeeded!") return nil }