The adb-data-storage-vnet-ncc-private-endpoint and adb-data-storage-vnet-ncc-public-endpoint examples (and their backing modules) are near-duplicates. The public-vs-private endpoint choice is effectively a single toggle, not a reason to maintain two parallel trees.
Measured overlap (modules):
- Byte-identical:
adb-vnet.tf (126 lines), adb-ws.tf (109 lines), dbx-uc-external-location.tf (76 lines)
- Near-identical (<25 differing lines each):
dbx-ncc.tf, dbx-uc-data-storage.tf, dbx-uc-object-catalog.tf, providers.tf, variables.tf
- Unique to the private variant: only the 4 private-link files
dbx-uc-data-storagencc-pl.tf, dbx-uc-data-storagevnet-pl.tf, dbx-uc-dbfs-storagencc-pl.tf, dbx-uc-dbfs-storagevnet-pl.tf
- Example level:
main.tf differs by 5 lines, variables.tf by 8
Proposal: merge into a single example + module, with a variable to toggle public/private endpoint behavior.
Related to #99 (broader effort to make the Azure network examples more modular / less duplicated).
The
adb-data-storage-vnet-ncc-private-endpointandadb-data-storage-vnet-ncc-public-endpointexamples (and their backing modules) are near-duplicates. The public-vs-private endpoint choice is effectively a single toggle, not a reason to maintain two parallel trees.Measured overlap (modules):
adb-vnet.tf(126 lines),adb-ws.tf(109 lines),dbx-uc-external-location.tf(76 lines)dbx-ncc.tf,dbx-uc-data-storage.tf,dbx-uc-object-catalog.tf,providers.tf,variables.tfdbx-uc-data-storagencc-pl.tf,dbx-uc-data-storagevnet-pl.tf,dbx-uc-dbfs-storagencc-pl.tf,dbx-uc-dbfs-storagevnet-pl.tfmain.tfdiffers by 5 lines,variables.tfby 8Proposal: merge into a single example + module, with a variable to toggle public/private endpoint behavior.
Related to #99 (broader effort to make the Azure network examples more modular / less duplicated).