From c5f5fa7c84140dd3ca6b806f9e81fcd171fb94ec Mon Sep 17 00:00:00 2001 From: Prathamesh Baviskar Date: Tue, 11 Aug 2026 08:00:37 +0000 Subject: [PATCH 1/2] Add telemetry error classification guardrails Signed-off-by: Prathamesh Baviskar --- .github/CODEOWNERS | 4 ++++ .github/PULL_REQUEST_TEMPLATE.md | 12 +++++++++++- CLAUDE.md | 13 +++++++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 0a02120de5..193d5955d7 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,3 +1,7 @@ # Require review for changes to GitHub Actions workflows and CI configuration .github/workflows/ @databricks/eng-oss-sql-driver .github/CODEOWNERS @databricks/eng-oss-sql-driver + +# Telemetry error-code changes require driver-owner review because they also need +# classification in the maintainers' dashboard and automation taxonomy. +src/main/java/com/databricks/jdbc/model/telemetry/enums/DatabricksDriverErrorCode.java @databricks/eng-oss-sql-driver diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index db38946224..2105aad48c 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -4,7 +4,17 @@ ## Testing +## Telemetry Errors + +- [ ] Not applicable — this PR does not add or change a telemetry-visible error. +- [ ] Applicable — the error uses `DatabricksDriverErrorCode` where appropriate, and any + new code is uniquely numbered and tested. +- [ ] Applicable — its driver/server/user classification is linked, or maintainer help is + requested because the author cannot access the classification. + ## Additional Notes to the Reviewer - diff --git a/CLAUDE.md b/CLAUDE.md index b6b803ef15..9b9b831134 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -14,6 +14,19 @@ - `src/test/java/com/databricks/jdbc/` — unit and integration tests - `development/.release-freeze.json` — controls release freeze state +## Telemetry Error Changes + +When adding or changing an error emitted by the JDBC driver: + +- Use `DatabricksDriverErrorCode` wherever a driver-owned error code applies. Reuse an + existing code when its meaning matches; otherwise add a uniquely numbered enum value. +- Add or update a test that verifies the emitted error name and numeric code. +- Record whether the error is a driver, server, or user error in the maintainers' OSS JDBC + telemetry dashboard and automation taxonomy. Link that update in the PR, or explicitly + ask a maintainer to make it if you do not have access. Do not infer the classification + from the error name alone. +- Complete the telemetry-error section of the pull-request template. + ## PR Checks — Common Pitfalls ### 1. DCO Sign-off (required) From 52958f99c687e3471e61cb4aaffa3fa4295f7c23 Mon Sep 17 00:00:00 2001 From: Prathamesh Baviskar Date: Tue, 18 Aug 2026 06:11:34 +0000 Subject: [PATCH 2/2] Remove telemetry CODEOWNERS routing Signed-off-by: Prathamesh Baviskar --- .github/CODEOWNERS | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 193d5955d7..0a02120de5 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,7 +1,3 @@ # Require review for changes to GitHub Actions workflows and CI configuration .github/workflows/ @databricks/eng-oss-sql-driver .github/CODEOWNERS @databricks/eng-oss-sql-driver - -# Telemetry error-code changes require driver-owner review because they also need -# classification in the maintainers' dashboard and automation taxonomy. -src/main/java/com/databricks/jdbc/model/telemetry/enums/DatabricksDriverErrorCode.java @databricks/eng-oss-sql-driver