Skip to content
This repository was archived by the owner on Aug 8, 2025. It is now read-only.

Commit 29d6cf6

Browse files
committed
Don't use basic image, update to 0.12.0
1 parent b0f03fb commit 29d6cf6

5 files changed

Lines changed: 7 additions & 23 deletions

File tree

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
FROM datacatering/data-caterer-basic:0.11.8
1+
FROM datacatering/data-caterer:0.12.0
22

33
COPY --chown=app:app build/libs/data-caterer-example-0.1.0.jar /opt/app/job.jar

benchmark/run_benchmark.sh

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ enable_data_size_run=${ENABLE_DATA_SIZE_RUN:-true}
55
enable_data_sink_run=${ENABLE_DATA_SINK_RUN:-true}
66

77
data_caterer_version=$(grep dataCatererVersion gradle.properties | cut -d= -f2)
8-
image_suffix="-basic"
98
default_job="io.github.datacatering.plan.benchmark.BenchmarkParquetPlanRun"
109
#default_job="io.github.datacatering.plan.benchmark.BenchmarkValidationPlanRun"
1110
default_record_count="100000"
@@ -61,7 +60,7 @@ run_docker() {
6160
-e "$driver_memory" \
6261
-e "$executor_memory" \
6362
-e "ADDITIONAL_OPTS=$additional_conf" \
64-
datacatering/data-caterer"$image_suffix":"$data_caterer_version";
63+
datacatering/data-caterer:"$data_caterer_version";
6564
} 2>&1 | grep "real " | sed "$sed_option" "s/^.*real ([0-9\.]+)$/\1/")
6665
echo "Time taken: $time_taken"
6766
if [[ $1 == *BenchmarkForeignKeyPlanRun* ]]; then
@@ -81,7 +80,7 @@ if [[ $? -ne 0 ]]; then
8180
fi
8281

8382
echo "Pulling image before starting benchmarks"
84-
docker pull datacatering/data-caterer"$image_suffix":"$data_caterer_version"
83+
docker pull datacatering/data-caterer:"$data_caterer_version"
8584

8685
echo "Running benchmarks"
8786
if [[ "$enable_query_engine_run" == true ]]; then
@@ -105,9 +104,6 @@ if [[ "$enable_data_sink_run" == true ]]; then
105104
for job in "${job_names[@]}"; do
106105
echo "Running for job: $job"
107106
full_class_name="io.github.datacatering.plan.benchmark.$job"
108-
if [[ "$job" == *"Advanced"* ]]; then
109-
image_suffix=""
110-
fi
111107
run_docker "$full_class_name" "$default_record_count"
112108
done
113109
fi
@@ -118,5 +114,5 @@ echo "Printing logs of last docker run"
118114
docker ps -a | awk -F " " '{print $1}' | tail -1 | xargs docker logs
119115

120116
echo "Cleaning docker runs..."
121-
docker ps -a | grep "datacatering/data-caterer-basic" | awk -F " " '{print $1}' | xargs docker rm
117+
docker ps -a | grep "datacatering/data-caterer" | awk -F " " '{print $1}' | xargs docker rm
122118
echo "Done!"

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@ version=0.1.0
88

99
scalaVersion=2.12
1010
scalaSpecificVersion=2.12.19
11-
dataCatererVersion=0.11.11
11+
dataCatererVersion=0.12.0
1212
sparkVersion=3.5.1
1313
sparkMajorVersion=3.5

helm/data-caterer/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ image:
88
repository: "datacatering/data-caterer"
99
pullPolicy: "IfNotPresent"
1010
# Overrides the image tag whose default is the chart appVersion.
11-
tag: "0.11.8"
11+
tag: "0.12.0"
1212

1313
imagePullSecrets: []
1414
nameOverride: ""

run.sh

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,6 @@ else
2121
fi
2222
echo -n "$curr_class_name" > .tmp_prev_class_name
2323

24-
image_suffix="-basic"
25-
additional_env_vars=""
26-
if [[ "$curr_class_name" == *"Advanced"* ]]; then
27-
if [[ -z "$DATA_CATERING_API_KEY" ]]; then
28-
image_suffix=""
29-
else
30-
image_suffix="-trial"
31-
additional_env_vars=" -e API_KEY=$DATA_CATERING_API_KEY"
32-
fi
33-
fi
34-
3524
echo "Building jar with plan run"
3625
./gradlew clean build
3726
if [[ $? -ne 0 ]]; then
@@ -54,9 +43,8 @@ DOCKER_CMD=(
5443
-e "DEPLOY_MODE=client"
5544
-e "DRIVER_MEMORY=2g"
5645
-e "EXECUTOR_MEMORY=2g"
57-
"$additional_env_vars"
5846
--network "docker_default"
59-
datacatering/data-caterer"$image_suffix":"$data_caterer_version"
47+
datacatering/data-caterer:"$data_caterer_version"
6048
)
6149

6250
eval "${DOCKER_CMD[@]}"

0 commit comments

Comments
 (0)