fix: resolve pylint warnings in agentstudio test files

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: foleydang

tests/unit/test_agentstudio_skills.py

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=protected-access
 """Skill resource shape & auto-upload compatibility.
 
 Tests create a client with a mocked transport and patch Files.upload
@@ -23,27 +24,32 @@ def __init__(self):
     def request(self, method, path, **kwargs):
         self.calls.append({"method": method, "path": path, **kwargs})
         if "/versions" in path:
-            return APIResponse(data={"id": "skv_1", "skill_id": "skl_1", "version": 1}, request_id="req_2")
+            return APIResponse(
+                data={"id": "skv_1", "skill_id": "skl_1", "version": 1},
+                request_id="req_2",
+            )
         if path == "/skills":
-            return APIResponse(data={"id": "skl_1", "name": "demo"}, request_id="req_1")
+            return APIResponse(
+                data={"id": "skl_1", "name": "demo"}, request_id="req_1"
+            )
         return APIResponse(data={}, request_id=None)
 
 
-@pytest.fixture
-def client():
+@pytest.fixture(name="client")
+def _client_fixture():
     """Create a client with a recording transport."""
     c = Client(api_key="test-key")
     c._transport = _Tx()
     return c
 
 
-@pytest.fixture
-def fake_upload(client, monkeypatch):
+@pytest.fixture(name="fake_upload")
+def _fake_upload_fixture(client, monkeypatch):
     """Patch Files.upload on the client's files instance to record calls."""
     calls: List[Dict[str, Any]] = []
     file_id_holder = {"id": "file_auto"}
 
-    def _upload(self_files, file, *, mime_type=None, **kwargs):
+    def _upload(_self_files, file, *, mime_type=None, **_kwargs):
         calls.append({"file": file, "mime_type": mime_type})
 
         class _F:
@@ -111,7 +117,9 @@ def test_skill_versions_create_with_file_id_no_upload(client, fake_upload):
     assert body == {"file_id": "file_existing"}
 
 
-def test_skill_versions_create_explicit_mime_type_overrides(client, fake_upload):
+def test_skill_versions_create_explicit_mime_type_overrides(
+    client, fake_upload
+):
     upload_calls, _ = fake_upload
 
     sv = SkillVersions(client)

tests/unit/test_agentstudio_tools.py

@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-"""Tests for the @tool decorator schema synthesis and JSON Schema validation."""
+"""@tool decorator schema synthesis and JSON Schema validation."""
 
 from typing import List, Optional
 
@@ -42,17 +42,21 @@ def get_weather(city: str, unit: str = "C") -> str:
 def test_tool_decorator_optional_and_list():
     @tool(name="search", description="Custom desc")
     def _search(q: str, limit: Optional[int] = None, tags: List[str] = None):
-        return []
+        return [q, limit, tags]
 
     spec = _search.__tool_spec__
     assert spec.name == "search"
     assert spec.description == "Custom desc"
     props = spec.parameters["properties"]
     assert props["q"] == {"type": "string"}
-    # Optional[int] -> integer with default=None (API needs to know it's optional)
+    # Optional[int] -> integer with default=None
     assert props["limit"] == {"type": "integer", "default": None}
     # List[str] -> array of strings
-    assert props["tags"] == {"type": "array", "items": {"type": "string"}, "default": None}
+    assert props["tags"] == {
+        "type": "array",
+        "items": {"type": "string"},
+        "default": None,
+    }
     assert spec.parameters["required"] == ["q"]
 
 
@@ -63,7 +67,9 @@ def identity(text: str) -> str:
         return text
 
     desc = identity.__tool_spec__.to_descriptor()
-    assert "type" not in desc, "BMA backend does not accept 'type' field for custom tools"
+    assert (
+        "type" not in desc
+    ), "BMA backend does not accept 'type' field for custom tools"
     assert desc["name"] == "identity"
     assert desc["input_schema"]["properties"]["text"] == {"type": "string"}
 
@@ -91,7 +97,7 @@ def test_default_value_is_emitted_into_schema():
     @tool
     def search(q: str, limit: int = 10) -> str:
         """Search the index."""
-        return ""
+        return f"{q}{limit}"
 
     schema = search.__tool_spec__.parameters
     _validate(schema)
@@ -103,20 +109,22 @@ def test_optional_strips_none_keeps_inner_type():
     @tool
     def lookup(name: str, hint: Optional[int] = None) -> str:
         """Look something up."""
-        return ""
+        return f"{name}{hint}"
 
     schema = lookup.__tool_spec__.parameters
     _validate(schema)
     assert schema["properties"]["hint"]["type"] == "integer"
-    assert schema["properties"]["hint"]["default"] is None  # None default is preserved
+    assert (
+        schema["properties"]["hint"]["default"] is None
+    )  # None default is preserved
     assert "hint" not in schema["required"]
 
 
 def test_list_inner_type_is_validated():
     @tool
     def tag(names: List[str]) -> str:
         """Tag inputs."""
-        return ""
+        return str(names)
 
     schema = tag.__tool_spec__.parameters
     _validate(schema)
@@ -135,14 +143,17 @@ def make_order(item: str, qty: int = 1) -> str:
             item: SKU identifier of the product to order.
             qty: How many units to request. Defaults to 1.
         """
-        return ""
+        return f"{item}{qty}"
 
     schema = make_order.__tool_spec__.parameters
     _validate(schema)
     assert schema["properties"]["item"]["description"] == (
         "SKU identifier of the product to order."
     )
-    assert "How many units to request" in schema["properties"]["qty"]["description"]
+    assert (
+        "How many units to request"
+        in schema["properties"]["qty"]["description"]
+    )
     # Top-level summary trims the Args section
     assert make_order.__tool_spec__.description == "Place a supply order."
 
@@ -155,7 +166,7 @@ def fetch(url: str, timeout: float = 5.0) -> str:
         :param url: The fully qualified URL to download.
         :param timeout: Per-request timeout in seconds.
         """
-        return ""
+        return f"{url}{timeout}"
 
     schema = fetch.__tool_spec__.parameters
     _validate(schema)
@@ -174,7 +185,7 @@ def test_descriptor_round_trip_validates_arguments():
     @tool
     def ping(host: str, count: int = 1) -> str:
         """Ping a host."""
-        return ""
+        return f"{host}{count}"
 
     schema = ping.__tool_spec__.to_descriptor()["input_schema"]
     _validate(schema)