Skip to content

ApiKey is referenced under two different names, neither of which resolves #15

Description

@Snider

Found while making the package installable and testable (#13).

The package refers to an ApiKey model under two competing names, and neither resolves:

Core\Mod\Api\Models\ApiKey    5 files  (Website/Mcp/View/Modal/ApiKeyManager, .../Playground,
                                        Mcp/View/Modal/Admin/{McpPlayground,ApiKeyManager,Playground})
Core\Api\Models\ApiKey        1 file   (Mcp/Middleware/McpApiKeyAuth)

dappcore/php maps Core\src/Core/, Core\Mod\src/Mod/, Core\Website\ and Core\Plug\. Neither src/Core/Api/Models/ApiKey.php nor src/Mod/Api/Models/ApiKey.php exists, so both names are dead. At minimum the two spellings cannot both be right.

Searching the estate finds exactly one ApiKey class:

~/Code/core/agent/php/Mod/Api/Models/ApiKey.php
namespace Core\Mod\Agentic\Mod\Api\Models;

That is in dappcore/agent, the consumer — so repointing at it would deepen the dependency cycle tracked separately, not fix anything. Its namespace also looks accidental: the doubled Mod falls out of agent mapping Core\Mod\Agentic\php/ with the file sitting at php/Mod/Api/Models/, which suggests it was meant to be a standalone Core\Mod\Api\ package that was never extracted.

Deliberately not deleted and not repointed — per the standing rule a dangling reference is badly linked rather than invented, but here the only candidate is in the wrong repo, so a rewrite would be a guess.

Decision needed: extract ApiKey into a shared package under Core\Mod\Api\ (which is what five of the six call sites already expect), or confirm the API module belongs to dappcore/php and add it there. Then settle on one spelling and fix McpApiKeyAuth, which disagrees with the other five.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions