From eeb6b8ad70d53263153e4f71b8e4590072ed1de3 Mon Sep 17 00:00:00 2001
From: cuioss oliver <23139298+cuioss@users.noreply.github.com>
Date: Thu, 30 Jul 2026 10:13:23 +0200
Subject: [PATCH] fix(benchmarks): drop the leftover bash tail in the coverage
 step
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When the coverage step was switched to call benchmark-manifest.py summarise, the
replacement missed a trailing fragment of the bash implementation it superseded: a
truncation-narrative block and a final echo, both still referencing ${missing} and
${missing_names}, which no longer exist.

The first post-merge Performance Benchmark run shows the effect — two verdict
lines, the second with an empty count:

  Benchmark coverage: 0 of 12 expected summary document(s) absent (...)
  Benchmark coverage:  expected summary document(s) absent (...)

The duplicate line is cosmetic, but the truncation block is not. The step runs
under `bash -e`, and `[ "${missing}" -gt 0 ]` with an unset operand is a syntax
error, so on a FAILED benchmark run the step would abort instead of printing the
narrative — the one case the narrative exists for. That path had not run yet.

summarise already emits that narrative, in both the truncated and
not-truncated forms, so this is a pure deletion with no replacement needed.

Co-Authored-By: Claude <noreply@anthropic.com>
---
 .github/workflows/benchmark.yml | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
index ae2b7f27..58583edb 100644
--- a/.github/workflows/benchmark.yml
+++ b/.github/workflows/benchmark.yml
@@ -160,23 +160,6 @@ jobs:
             --benchmark-outcome "${BENCHMARK_OUTCOME}" \
             --summary-file "$GITHUB_STEP_SUMMARY"
 
-          # When Maven failed, the DID NOT RUN rows above and the Maven error are almost always the
-          # same event, but nothing on the page says so — a reader is left to infer the causal link.
-          # State it. This path never exits non-zero: the benchmark step's own failure already fails
-          # the job, and duplicating that here would only bury the real error.
-          if [ "${BENCHMARK_OUTCOME}" != "success" ]; then
-            {
-              echo
-              if [ "${missing}" -gt 0 ]; then
-                echo "> **Maven failed and the suite was TRUNCATED**: goals ${missing_names} produced no summary because the run aborted before reaching them. The DID NOT RUN rows above are a consequence of that failure, not ${missing} independent problems — fix the reported Maven error first, then re-read this table."
-              else
-                echo "> **Maven failed AFTER every expected goal produced a summary.** No goal was lost to truncation, so the failure lies outside goal execution (post-processing, the baseline comparison, or container teardown). The results above are complete and usable."
-              fi
-            } >> "$GITHUB_STEP_SUMMARY"
-          fi
-
-          echo "Benchmark coverage: ${missing} expected summary document(s) absent (benchmark step outcome: ${BENCHMARK_OUTCOME})."
-
       - name: Assemble benchmark artifacts for deployment
         run: |
           python3 benchmarks/scripts/benchmark-pages.py assemble \