NIPA final demand flowsa code appear to be looking for a method that doesn't exist

[WesIngwersen]

USEEIO/nowcasting/nipa_final_demand_estimates.py

Lines 51 to 56 in 06bda7c

	#%% Generate the FBS for other demands (see NIPA_FD_Common.yaml)
	name=f'NIPA_FD_{y}'
	if regenerateFBS:
	FlowBySector.generateFlowBySector(name, append_sector_names=True,
	download_sources_ok=True,
	external_config_path=fbsMethodPath)

This doesn't work because there are no methods for different years in the dedicated branch of flowsa, just a common method

https://github.com/cornerstone-data/flowsa/tree/nipa/flowsa/methods/flowbysectormethods

The code will run if the common methods is renamed to NIPA_FD_2017

[WesIngwersen]

FYI @bl-young

[WesIngwersen]

Actually my NIPA_FD_2017 is saved locally but it's empty after making this change. It could be in my case due to overriding the flowsa requirements and using the most recent pandas and numpy packages

[bl-young]

It should be using the methods in https://github.com/cornerstone-data/USEEIO/tree/nowcasting/nowcasting/flowsa_fbs, which are just year-by-year versions that rely on the common FBS method in flowsa itself.