Skip to content

Remove before_transform and after_transform and allow more PyTorch lightning like hooks (that interfere execution process) and TransformTemplate #24

Description

@hmirin
  • Hooks are a legacy of old implementations that allow jumps etc...

  • Now, that isn't good because:

    • the order of execution is obscured by the existence of hooks. rendering and hooks are somewhat duplicated ideas because both may transform data. It adds just complexity.
  • We should add TransformTemplate

  • The importance is user should find it easy to grasp the logic.

  • The transform is like Keras's one. That can be combined as a layer. We should make such a thing.

  • PyTorch Lightning-like hooks are not like the current implementation.

    • That should be: record every template execution to remote such as w&b
    • We should make such hooks to enable the logging feature.
  • We should also remove the need to template_id (because some of it is required by jump feature)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions