Skip to content

Commit ace53d0

Browse files
committed
refactor(events): remove unsupported mark validation from bulkToggleEventMarks and clean up related tests
1 parent dd84f03 commit ace53d0

2 files changed

Lines changed: 0 additions & 26 deletions

File tree

src/resolvers/event.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -170,10 +170,6 @@ module.exports = {
170170
* @return {Promise<{ updatedCount: number, updatedEventIds: string[], failedEventIds: string[] }>}
171171
*/
172172
async bulkToggleEventMarks(_obj, { projectId, eventIds, mark }, context) {
173-
if (mark !== 'resolved' && mark !== 'ignored' && mark !== 'starred') {
174-
throw new UserInputError('bulkToggleEventMarks supports only resolved, ignored and starred marks');
175-
}
176-
177173
const { validEventIds, invalidEventIds } = parseBulkEventIds(eventIds);
178174

179175
if (validEventIds.length === 0) {

test/resolvers/event-bulk-toggle-marks.test.ts

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import '../../src/env-test';
22

3-
import { UserInputError } from 'apollo-server-express';
4-
53
jest.mock('../../src/resolvers/helpers/eventsFactory', () => ({
64
__esModule: true,
75
default: jest.fn(),
@@ -31,26 +29,6 @@ describe('Mutation.bulkToggleEventMarks', () => {
3129
});
3230
});
3331

34-
it('should throw when mark is not supported', async () => {
35-
await expect(
36-
eventResolvers.Mutation.bulkToggleEventMarks(
37-
{},
38-
{ projectId: 'p1', eventIds: [ '507f1f77bcf86cd799439012' ], mark: 'some-unknown-mark' },
39-
ctx
40-
)
41-
).rejects.toThrow(UserInputError);
42-
43-
await expect(
44-
eventResolvers.Mutation.bulkToggleEventMarks(
45-
{},
46-
{ projectId: 'p1', eventIds: [ '507f1f77bcf86cd799439012' ], mark: 'some-unknown-mark' },
47-
ctx
48-
)
49-
).rejects.toThrow('bulkToggleEventMarks supports only resolved, ignored and starred marks');
50-
51-
expect(bulkToggleEventMark).not.toHaveBeenCalled();
52-
});
53-
5432
it('should throw when eventIds is empty', async () => {
5533
await expect(
5634
eventResolvers.Mutation.bulkToggleEventMarks(

0 commit comments

Comments
 (0)