fix(resolvers): improve create rule data validation

Author: e11sy

src/resolvers/projectNotifications.ts

@@ -107,6 +107,7 @@ export default {
       { user, factories }: ResolverContextWithUser
     ): Promise<ProjectNotificationsRuleDBScheme> {
       const project = await factories.projectsFactory.findById(input.projectId);
+      const validThresholdPeriods = [60_000, 3_600_000, 86_400_000, 604_800_000]
 
       if (!project) {
         throw new ApolloError('No project with such id');
@@ -116,6 +117,10 @@ export default {
         throw new UserInputError('At least one channel is required');
       }
 
+      if (!validThresholdPeriods.includes(input.thresholdPeriod)) {
+        throw new UserInputError('Threshold period should be one of the following: 60000, 3600000, 86400000, 604800000');
+      }
+      
       return project.createNotificationsRule({
         ...input,
         uidAdded: user.id,

src/typeDefs/projectNotifications.ts

@@ -16,31 +16,6 @@ export default gql`
     SEEN_MORE
   }
 
-  """
-  Allowed threshold periods in milliseconds
-  """
-  enum ThresholdPeriod {
-    """
-    One minute in milliseconds
-    """
-    MINUTE = 60000
-
-    """
-    One hour in milliseconds
-    """
-    HOUR = 3600000
-
-    """
-    One day in milliseconds
-    """
-    DAY = 86400000
-
-    """
-    One week in milliseconds
-    """
-    WEEK = 604800000
-  }
-
   """
   Project notify settings
   """
@@ -83,6 +58,6 @@ export default gql`
     """
     Period to receive notification
     """
-    thresholdPeriod: ThresholdPeriod
+    thresholdPeriod: Int
   }
 `;

src/typeDefs/projectNotificationsMutations.ts

@@ -43,7 +43,7 @@ export default gql`
     """
     Period to receive notification
     """
-    thresholdPeriod: ThresholdPeriod
+    thresholdPeriod: Int
   }
 
   """
@@ -93,7 +93,7 @@ export default gql`
     """
     Period to receive notification
     """
-    thresholdPeriod: ThresholdPeriod
+    thresholdPeriod: Int
   }
 
   """