refactor: generalize remote environment helpers

Author: EhabY

src/remote/proxyEnvironment.ts src/remote/environment.tssrc/remote/proxyEnvironment.ts renamed to src/remote/environment.ts

@@ -2,6 +2,11 @@ import { getProxyForUrl } from "../api/proxy";
 
 import type { WorkspaceConfiguration } from "vscode";
 
+// Remote-SSH inherits this extension host's process environment only for
+// processes it starts after these values are applied. This is best-effort for
+// settings like remote.SSH.useLocalServer, where an existing local server may
+// already be running with an older environment.
+
 export type SshProxyEnvironment = Partial<
 	Record<"HTTP_PROXY" | "HTTPS_PROXY" | "NO_PROXY", string>
 >;

src/remote/remote.ts

@@ -61,7 +61,7 @@ import {
 import { vscodeProposed } from "../vscodeProposed";
 import { WorkspaceMonitor } from "../workspace/workspaceMonitor";
 
-import { applySshProxyEnvironment } from "./proxyEnvironment";
+import { applySshProxyEnvironment } from "./environment";
 import {
 	SshConfig,
 	type SshValues,

test/unit/remote/proxyEnvironment.test.ts test/unit/remote/environment.test.tstest/unit/remote/proxyEnvironment.test.ts renamed to test/unit/remote/environment.test.ts

@@ -1,9 +1,10 @@
+import { spawnSync } from "node:child_process";
 import { describe, it, expect, beforeEach, vi } from "vitest";
 
 import {
 	applySshProxyEnvironment,
 	getSshProxyEnvironment,
-} from "@/remote/proxyEnvironment";
+} from "@/remote/environment";
 
 import { MockConfigurationProvider } from "../../mocks/testHelpers";
 
@@ -125,4 +126,29 @@ describe("applySshProxyEnvironment", () => {
 			https_proxy: "http://old-https-proxy.example.com:8080",
 		});
 	});
+
+	it("propagates proxy variables to child processes", () => {
+		const cfg = new MockConfigurationProvider();
+		cfg.set("http.proxy", proxy);
+		const applied = applySshProxyEnvironment("https://coder.example.com", cfg);
+
+		try {
+			const result = spawnSync(
+				process.execPath,
+				[
+					"-e",
+					"process.stdout.write(JSON.stringify({ http: process.env.HTTP_PROXY || process.env.http_proxy, https: process.env.HTTPS_PROXY || process.env.https_proxy }))",
+				],
+				{ encoding: "utf8" },
+			);
+
+			expect(result.status).toBe(0);
+			expect(JSON.parse(result.stdout)).toEqual({
+				http: proxy,
+				https: proxy,
+			});
+		} finally {
+			applied.dispose();
+		}
+	});
 });