Skip to content

flake: TestRenderChart (listenerset variants) #1611

Description

@flake-investigator

CI Run Link: https://github.com/coder/coder/actions/runs/28393869832

Commit: d0f68cb9b0e4f1b45a871859edd5b5517ce6c339 (Oliver Meyer) coder/coder@d0f68cb
Failure Date: 2026-06-29

What failed:

  • gen job: ./scripts/check_unstaged.sh reported unstaged changes in Helm golden files
  • test-go-pg, test-go-pg-17, test-go-race-pg: helm/coder/tests TestRenderChart subtests
    • TestRenderChart/default/listenerset
    • TestRenderChart/default/listenerset_redirect
    • TestRenderChart/coder/listenerset

Key error output:

  • gen job:

    • Unstaged changes in:
      • helm/coder/tests/testdata/listenerset.golden
      • helm/coder/tests/testdata/listenerset_coder.golden
      • helm/coder/tests/testdata/listenerset_redirect.golden
      • helm/coder/tests/testdata/listenerset_redirect_coder.golden
    • Diff snippet (example):
      • name: CODER_CLUSTER_HOST
        valueFrom:
        fieldRef:
        fieldPath: status.podIP
  • test-go-race-pg/test-go-pg/test-go-pg-17:

    • Expected vs actual diff adds the same env var:
      •    - name: CODER_CLUSTER_HOST
        
      •      valueFrom:
        
      •        fieldRef:
        
      •          fieldPath: status.podIP
        

Root Cause: Code change added CODER_CLUSTER_HOST to the helm chart output, but the listenerset* golden files were not regenerated/committed, so TestRenderChart comparisons and gen check_unstaged fail deterministically.

Assignment Analysis (per ownership rules):

  • git log --oneline -10 helm/coder/templates/coder.yaml
    • d0f68cb9 feat: add listenerset (Oliver Meyer)
  • git log --oneline -10 helm/coder/tests/testdata/listenerset.golden
    • d0f68cb9 feat: add listenerset (Oliver Meyer)
  • git log --oneline -10 helm/coder/tests/chart_test.go
    • cd92220 feat(helm): add setting to disable service account creation (MaxTNielsen)

Most recent meaningful changes to the helm template and listenerset golden files are in d0f68cb9 (Oliver Meyer), so assigning to Ben Potter (co-author) for helm chart ownership triage.

Reproduction:

  • go test ./helm/coder/tests -run TestRenderChart -count=1
  • To fix: go test ./helm/coder/tests -update and commit updated golden files (also re-run make gen to verify clean working tree)

Related Issues:

  • None found (searches: listenerset, CODER_CLUSTER_HOST, TestRenderChart, helm/coder/tests)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions