Extend other than BaseController?

[gphg]

What if my application's base abstraction controller is not BaseController, but something else? The Shield's controllers won't able to extended it.

My way to fix it is by rewrite the package's controller into application's.

[kenjis]

My way to fix it is by rewrite the package's controller into application's.

No problem. You can fully customize the controller.

[kenjis]

I don't know this is good or bad, how about moving the all logic in a Shield controller to a trait?

[lonnieezell]

Not a fan of that option.

I don't know there is a great solution for this, honestly. In CodeIgniter's user guide we recommend extending BaseController for all controllers, so I still think it makes sense to handle that here.

As much as I hate to say it, I think the solution may be to add a note to the docs for this specific situation, saying that you'll have to copy the controllers and extend the proper base controller.

[gphg]

I thought things such as class alias or psr mapping (done in composer.json) can achieved this.

[lonnieezell]

I hadn't really considered that, but ... maybe?

class_alias will always load that file on every request whether needed or not, IIRC.

PSR mapping might work - but I would have to try it. I think you would still end up with conflicts since the files have the App namespace hard-coded.

[kenjis]

What is PSR mapping?

If you can use App\Controllers\BaseController as an alias, it seems better to use App as your app namespace.

[kenjis]

There is no need to inherit the controllers of Shield.
It is possible to write your controllers from scratch, or just copy the controllers of Shield and modify them as you like.

After all, the controllers in Shield are sample code, and the controllers in your app are essentially yours.