Error force user reset password after restore with magiclink

[caosdp-rs]

Hello!

I'm try force user change password after login with magiclink.

in Auth.php

public function loginRedirect(): string
    {
        if (session('magicLogin')) {
            return redirect()->route('set_password');
         }

php spark routes -h

| GET | change-password | » | \App\Controllers\PasswordReset::index | csrf session | toolbar |

but cause error

Config\Auth::loginRedirect(): Return value must be of type string, CodeIgniter\HTTP\RedirectResponse returned

[kenjis]

Config\Auth::loginRedirect(): Return value must be of type string, CodeIgniter\HTTP\RedirectResponse returned

Config\Auth::loginRedirect() must return URL string, not Response object.

[caosdp-rs]

docs/quickstart.md

Session Notification
You can detect if a user has finished the magic link login by checking for a session value, magicLogin. If they have recently completed the flow, it will exist and have a value of true.

if (session('magicLogin')) {
return redirect()->route('set_password');
}

[caosdp-rs]

this work!

  public array $redirects = [
        'register'    => '/',
        'login'       => '/manager',
        'logout'      => '/',
        'set_password'=> 'change-password-magic',
    ];

public function loginRedirect(): string
{
    if (session('magicLogin')) {
        $url = setting('Auth.redirects')['set_password'];
     }else{
        $url = setting('Auth.redirects')['login'];
     }
    return $this->getUrl($url);
}

[kenjis]

The following code is a sample code for a controller.

if (session('magicLogin')) {
    return redirect()->route('set_password');
}

https://github.com/codeigniter4/shield/blob/develop/docs/quickstart.md#session-notification

[datamweb]

Hi @caosdp-rs,
Your method is good.

public function loginRedirect(): string
{
    if (session('magicLogin')) {
        $url = setting('Auth.redirects')['set_password'];
     }else{
        $url = setting('Auth.redirects')['login'];
     }
    return $this->getUrl($url);
}

But I saw something in your code that I would like to explain a little. You could write your code more readable and beautiful.

public function loginRedirect(): string
{

 $url = setting('Auth.redirects')['login'];

  if (session('magicLogin')) {
      $url = setting('Auth.redirects')['set_password'];
   }

   return $this->getUrl($url);
}

As you can see, both of the above codes work correctly, but which one is better?
Write better code and be a better programmer by NEVER USING ELSE statements

You may not feel much difference here, but the habit of using else in code with high lines has some problems.

Another way could be as follows:

    public function loginRedirect(): string
    {
        if (session('magicLogin')) {
            return setting('Auth.redirects')['set_password'];
        }

        $url = setting('Auth.redirects')['login'];

        return $this->getUrl($url);
    }