Rename toolbar loader to be a regular JS file

* Rename toolbar loader to be a regular JS file

* Use `str_replace` instead of `window.appUrl`

Author: paulbalandan

system/Debug/Toolbar.php

@@ -435,9 +435,9 @@ public function respond()
             header('Content-Type: application/javascript');
 
             ob_start();
-            include $this->config->viewsPath . 'toolbarloader.js.php';
+            include $this->config->viewsPath . 'toolbarloader.js';
             $output = ob_get_clean();
-            $output = substr($output, 8, -10); // trim the script tags
+            $output = str_replace('{url}', rtrim(site_url(), '/'), $output);
             echo $output;
 
             exit;

…Debug/Toolbar/Views/toolbarloader.js.php …tem/Debug/Toolbar/Views/toolbarloader.jssystem/Debug/Toolbar/Views/toolbarloader.js.php renamed to system/Debug/Toolbar/Views/toolbarloader.js system/Debug/Toolbar/Views/toolbarloader.js.php renamed to system/Debug/Toolbar/Views/toolbarloader.js

@@ -1,7 +1,3 @@
-<?php if (ENVIRONMENT === 'testing') {
-    return;
-} ?>
-<script>
 document.addEventListener('DOMContentLoaded', loadDoc, false);
 
 function loadDoc(time) {
@@ -12,7 +8,7 @@ function loadDoc(time) {
 
     localStorage.setItem('debugbar-time-new', time);
 
-    let url = "<?= rtrim(site_url(), '/') ?>";
+    let url = '{url}';
     let xhttp = new XMLHttpRequest();
 
     xhttp.onreadystatechange = function() {
@@ -89,4 +85,3 @@ function newXHR() {
 }
 
 window.XMLHttpRequest = newXHR;
-</script>