Fix Rector complaints

Author: MGatner

system/Psr/Cache/Item.php

@@ -160,7 +160,7 @@ public function set($value): self
 	/**
 	 * Sets the expiration time for this cache item.
 	 *
-	 * @param \DateTimeInterface|null $expiration
+	 * @param DateTimeInterface|null $expiration
 	 *   The point in time after which the item MUST be considered expired.
 	 *   If null is passed explicitly, a default value MAY be used. If none is set,
 	 *   the value should be stored permanently or for as long as the
@@ -190,7 +190,7 @@ public function expiresAt($expiration): self
 	/**
 	 * Sets the expiration time for this cache item.
 	 *
-	 * @param integer|\DateInterval|null $time
+	 * @param integer|DateInterval|null $time
 	 *   The period of time from the present after which the item MUST be considered
 	 *   expired. An integer parameter is understood to be the time in seconds until
 	 *   expiration. If null is passed explicitly, a default value MAY be used.

system/Psr/Cache/Pool.php

@@ -273,15 +273,7 @@ public function save(CacheItemInterface $item)
 		}
 
 		// Deteremine TTL
-		if ($expiration = $item->getExpiration())
-		{
-			$ttl = Time::now()->difference($expiration)->getSeconds();
-		}
-		// Set it never to expire
-		else
-		{
-			$ttl = 0;
-		}
+		$ttl = ($expiration = $item->getExpiration()) ? Time::now()->difference($expiration)->getSeconds() : 0;
 
 		return $this->adapter->save($item->getKey(), $item->get(), $ttl);
 	}

system/Psr/Cache/SimpleCache.php

@@ -49,9 +49,9 @@ public function get($key, $default = null)
 	/**
 	 * Persists data in the cache, uniquely referenced by a key with an optional expiration TTL time.
 	 *
-	 * @param string                     $key   The key of the item to store.
-	 * @param mixed                      $value The value of the item to store. Must be serializable.
-	 * @param null|integer|\DateInterval $ttl   Optional. The TTL value of this item. If no value is sent and
+	 * @param string                    $key   The key of the item to store.
+	 * @param mixed                     $value The value of the item to store. Must be serializable.
+	 * @param null|integer|DateInterval $ttl   Optional. The TTL value of this item. If no value is sent and
 	 *                                          the driver supports TTL then the library may set a default value
 	 *                                          for it or let the driver take care of that.
 	 *
@@ -154,8 +154,8 @@ public function getMultiple($keys, $default = null)
 	/**
 	 * Persists a set of key => value pairs in the cache, with an optional TTL.
 	 *
-	 * @param iterable                   $values A list of key => value pairs for a multiple-set operation.
-	 * @param null|integer|\DateInterval $ttl    Optional. The TTL value of this item. If no value is sent and
+	 * @param iterable                  $values A list of key => value pairs for a multiple-set operation.
+	 * @param null|integer|DateInterval $ttl    Optional. The TTL value of this item. If no value is sent and
 	 *                                           the driver supports TTL then the library may set a default value
 	 *                                           for it or let the driver take care of that.
 	 *
@@ -239,12 +239,7 @@ public function has($key)
 
 		$meta = $this->adapter->getMetaData($key);
 
-		// If the adapter does not return an array or if the item is expired then it is a miss
-		if (! is_array($meta) || (is_int($meta['expire']) && $meta['expire'] < time()))
-		{
-			return false;
-		}
-
-		return true;
+		// The adapter must return an array that is not expired
+		return is_array($meta) && is_int($meta['expire']) && $meta['expire'] > time();
 	}
 }