Merge pull request #4001 from totoprayogo1916/fix/form-helper

make form_hidden based on form_input

Author: samsonasik

system/Helpers/form_helper.php

@@ -158,7 +158,7 @@ function form_hidden($name, $value = '', bool $recursing = false): string
 
 		if (! is_array($value))
 		{
-			$form .= '<input type="hidden" name="' . $name . '" value="' . esc($value) . "\" style=\"display:none;\" />\n";
+			$form .= form_input($name, $value, '', 'hidden');
 		}
 		else
 		{

tests/system/Helpers/FormHelperTest.php

@@ -170,8 +170,8 @@ public function testFormOpenWithHidden()
 			$Name     = csrf_token();
 			$expected = <<<EOH
 <form action="http://example.com/index.php/foo/bar" name="form" id="form" method="POST" accept-charset="utf-8">
-<input type="hidden" name="foo" value="bar" style="display:none;" />
-<input type="hidden" name="$Name" value="$Value" style="display:none;" />
+<input type="hidden" name="foo" value="bar"  />
+<input type="hidden" name="$Name" value="$Value"  />
 
 EOH;
 		}
@@ -180,7 +180,7 @@ public function testFormOpenWithHidden()
 			$expected = <<<EOH
 <form action="http://example.com/index.php/foo/bar" name="form" id="form" method="POST" accept-charset="utf-8">
 
-<input type="hidden" name="foo" value="bar" style="display:none;" />
+<input type="hidden" name="foo" value="bar"  />
 
 EOH;
 		}
@@ -242,7 +242,7 @@ public function testFormHidden()
 	{
 		$expected = <<<EOH
 
-<input type="hidden" name="username" value="johndoe" style="display:none;" />\n
+<input type="hidden" name="username" value="johndoe"  />\n
 EOH;
 		$this->assertEquals($expected, form_hidden('username', 'johndoe'));
 	}
@@ -255,7 +255,7 @@ public function testFormHiddenArrayInput()
 		];
 		$expected = <<<EOH
 
-<input type="hidden" name="foo" value="bar" style="display:none;" />
+<input type="hidden" name="foo" value="bar"  />
 
 EOH;
 		$this->assertEquals($expected, form_hidden($data, null));
@@ -269,7 +269,7 @@ public function testFormHiddenArrayValues()
 		];
 		$expected = <<<EOH
 
-<input type="hidden" name="name[foo]" value="bar" style="display:none;" />
+<input type="hidden" name="name[foo]" value="bar"  />
 
 EOH;
 		$this->assertEquals($expected, form_hidden('name', $data));