Removed pointless isset() check

dafriend · dafriend · commit e52afb101dfc · 2019-11-14T08:58:01.000-06:00
Using isset($someVar) &amp;&amp; ! empty($someVar) in a conditional is redundant.
diff --git a/system/Router/RouteCollection.php b/system/Router/RouteCollection.php
@@ -1382,7 +1382,7 @@ protected function create(string $verb, string $from, $to, array $options = null
 		}
 
 		// Limiting to subdomains?
-		else if (isset($options['subdomain']) && ! empty($options['subdomain']))
+		else if (! empty($options['subdomain']))
 		{
 			// If we don't match the current subdomain, then
 			// we don't need to add the route.

Original file line number	Diff line number	Diff line change
`@@ -1382,7 +1382,7 @@ protected function create(string $verb, string $from, $to, array $options = null`
`1382`	`1382`	`}`
`1383`	`1383`
`1384`	`1384`	`// Limiting to subdomains?`
`1385`		`- else if (isset($options['subdomain']) && ! empty($options['subdomain']))`
	`1385`	`+ else if (! empty($options['subdomain']))`
`1386`	`1386`	`{`
`1387`	`1387`	`// If we don't match the current subdomain, then`
`1388`	`1388`	`// we don't need to add the route.`