Apply review suggestions

Author: MGatner

system/Helpers/filesystem_helper.php

@@ -91,20 +91,16 @@ function directory_map(string $sourceDir, int $directoryDepth = 0, bool $hidden
 	 */
 	function directory_mirror(string $originDir, string $targetDir, bool $overwrite = true): void
 	{
-		$originDir = rtrim($originDir, '\\/');
-		$targetDir = rtrim($targetDir, '\\/');
-
-		if (! is_dir($originDir))
+		if (! is_dir($originDir = rtrim($originDir, '\\/')))
 		{
 			throw new InvalidArgumentException(sprintf('The origin directory "%s" was not found.', $originDir));
 		}
 
-		if (! is_dir($targetDir))
+		if (! is_dir($targetDir = rtrim($targetDir, '\\/')))
 		{
 			@mkdir($targetDir, 0755, true);
 		}
 
-
 		$dirLen = strlen($originDir);
 
 		/** @var SplFileInfo $file */
@@ -120,7 +116,7 @@ function directory_mirror(string $originDir, string $targetDir, bool $overwrite
 			{
 				mkdir($target, 0755);
 			}
-			elseif (! file_exists($target) || ($overwrite && is_file($target)))
+			elseif (! is_file($target) || ($overwrite && is_file($target)))
 			{
 				copy($origin, $target);
 			}

user_guide_src/source/helpers/filesystem_helper.rst

@@ -239,6 +239,19 @@ The following functions are available:
 
         echo octal_permissions(fileperms('./index.php')); // 644
 
+.. php:function:: same_file($file1, $file2)
+
+    :param	string	$file1: Path to the first file
+    :param	string	$file2: Path to the second file
+    :returns:	Whether both files exist with identical hashes
+    :rtype:	boolean
+
+    Compares two files to see if they are the same (based on their MD5 hash).
+
+    ::
+
+        echo same_file($newFile, $oldFile) ? 'Same!' : 'Different!';
+
 .. php:function:: set_realpath($path[, $check_existence = FALSE])
 
     :param	string	$path: Path