Merge branch 'develop' into response-setHeaderLink

Author: natanfelles

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,36 @@
+---
+name: Bug report
+about: Create a report to help us improve
+
+---
+
+---
+name: Bug report
+about: Help us improve the framework by reporting bugs!
+
+---
+
+**Direction**
+We use github issues to track bugs, not for support.  
+If you have a support question, or a feature request, raise these as threads on our
+[forum](https://forum.codeigniter.com/index.php).
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**CodeIgniter 4 version**
+Which version (and branch, if applicable) the bug is in.
+
+**Affected module(s)**
+Which package or class is the bug in, if known.
+
+**Expected behavior, and steps to reproduce if appropriate**
+A clear and concise description of what you expected to happen,
+and how you got there.  
+Feel free to include a text/log extract, but use a pastebin facility for any
+screenshots you deem necessary.
+
+**Context**
+ - OS: [e.g. Windows 99]
+ - Web server [e.g. Apache 1.2.3]
+ - PHP version [e.g. 6.5.4]

.gitignore

@@ -57,10 +57,20 @@ writable/logs/*
 !writable/logs/index.html
 !writable/logs/.htaccess
 
+writable/session/*
+!writable/session/index.html
+!writable/session/.htaccess
+
 writable/uploads/*
 !writable/uploads/index.html
 !writable/uploads/.htaccess
 
+writable/debugbar/*
+
+application/Database/Migrations/2*
+
+php_errors.log
+
 #-------------------------
 # User Guide Temp Files
 #-------------------------
@@ -120,3 +130,5 @@ nb-configuration.xml
 .vscode/
 
 /results/
+/phpunit*.xml
+

.nojekyll

@@ -1,20 +1,30 @@
 language: php
 
 php:
-  - 7
   - 7.1
+  - 7.2
+  - 7.3
+  - nightly
+
+matrix:
+  fast_finish: true
+  allow_failures:
+    - php: 7.3
+    - php: nightly
 
 global:
   - CI=true
   - CI_ENVIRONMENT=testing
 
 # Recommended by Travis support
 sudo: required
-dist: precise
+dist: trusty
+group: edge
 
 env:
   - DB=mysqli
   - DB=postgres
+  - DB=sqlite
 
 services:
   - memcached
@@ -36,4 +46,4 @@ before_script:
   - composer install --prefer-source
 
 after_success:
-  - travis_retry php tests/bin/coveralls.phar
+  - travis_retry php tests/bin/php-coveralls.phar -v

.travis.yml

@@ -0,0 +1,46 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at admin@codeigniter.com. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
+
+[homepage]: http://contributor-covenant.org
+[version]: http://contributor-covenant.org/version/1/4/

CODE_OF_CONDUCT.md

@@ -0,0 +1,22 @@
+Each pull request should address a single issue, and have a meaningful title.
+
+**Description**
+Explain what you have changed, and why.
+
+**Checklist:**
+- [ ] Securely signed commits
+- [ ] Component(s) with PHPdocs
+- [ ] Unit testing, with >80% coverage
+- [ ] User guide updated
+- [ ] Conforms to style guide
+
+---------Remove from here down in your description----------
+
+**Notes**
+- Pull requests must be in English
+- If the PR solves an issue, reference it with a suitable verb and the issue number
+(e.g. fixes <hash>12345
+- Unsolicited PRs will be considered, but there is no guarantee of acceptance
+- Pull requests should be from a feature branch in the contributor's fork of the repository
+  to the develop branch of the project repository
+  

PULL_REQUEST_TEMPLATE.md

@@ -1,7 +1,7 @@
 # CodeIgniter 4 Development
 
-[![Build Status](https://travis-ci.org/bcit-ci/CodeIgniter4.svg?branch=develop)](https://travis-ci.org/bcit-ci/CodeIgniter4)
-[![Coverage Status](https://coveralls.io/repos/github/bcit-ci/CodeIgniter4/badge.svg?branch=develop)](https://coveralls.io/github/bcit-ci/CodeIgniter4?branch=develop)
+[![Build Status](https://travis-ci.org/codeigniter4/CodeIgniter4.svg?branch=develop)](https://travis-ci.org/codeigniter4/CodeIgniter4)
+[![Coverage Status](https://coveralls.io/repos/github/codeigniter4/CodeIgniter4/badge.svg?branch=develop)](https://coveralls.io/github/codeigniter4/CodeIgniter4?branch=develop)
 <br>
 
 ## What is CodeIgniter?
@@ -18,7 +18,9 @@ More information about the plans for version 4 can be found in [the announcement
 
 ### Documentation
 
-The current documentation can be found [here](https://bcit-ci.github.io/CodeIgniter4/). As with the rest of the framwork, it is currently a work in progress, and will see changes over time to structure, explanations, etc.
+The current in-progress documentation can be found [here](https://codeigniter4.github.io/CodeIgniter4/). 
+As with the rest of the framework, it is currently a work in progress, and will see changes over time to structure, explanations, etc.
+
 
 ## Important Change with index.php
 
@@ -63,13 +65,20 @@ if you want to take the lead for one of them.
 
 We are not looking for out-of-scope contributions, only those that would be considered part of our controlled evolution!
 
-Please read the *Contributing to CodeIgniter* section in the user guide
+Please read the [*Contributing to CodeIgniter*](https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing.md) section in the user guide
 
 ## Server Requirements
-PHP version 7 or higher is required, with the following extensions installed: 
+PHP version 7.1 or higher is required, with the following extensions installed: 
+
+- [intl](http://php.net/manual/en/intl.requirements.php)
+- [libcurl](http://php.net/manual/en/curl.requirements.php) if you plan to use the HTTP\CURLRequest library
 
-- intl
+Additionally, make sure that the following extensions are enabled in your PHP:
 
+- json (enabled by default - don't turn it off)
+- [mbstring](http://php.net/manual/en/mbstring.installation.php)
+- [mysqlnd](http://php.net/manual/en/mysqlnd.install.php)
+- xml (enabled by default - don't turn it off)
 
 ## Running CodeIgniter Tests
 Information on running CodeIgniter test suite can be found in the [README.md](tests/README.md) file in the tests directory.

README.md

@@ -0,0 +1,76 @@
+#CodeIgniter 4 Admin
+
+This folder contains tools or docs useful for project maintainers.
+
+##Repositories Organization, inside https://github.com/codeigniter4
+
+-   **CodeIgniter4** is the main development repository.  
+    It supports issues and pull requests, and has a rule to enforce GPG-signed commits.  
+    In addition to the framework source, it includes unit testing and documentation source.  
+    The three repositories following are built from this one as part of the release workflow.  
+    This repo is meant to be forked by contributors.
+
+-   **framework** is the released developer repository.  
+    It contains all the main pieces of the framework that developers would use to
+    build their apps, but not the framework unit testing or the user guide source.  
+    It is meant to be downloaded by developers, or composer-installed.  
+    This is a read-only repository.
+-   **appstarter** is the released application starter repository.  
+    It is derived from the framework's `application` and `public` folders, with
+    a composer requirement dependency to pull in the framework itself.  
+    It is meant to be downloaded or composer-installed.  
+    This is a read-only repository.
+-   **userguide** is released documentation publishing repository.  
+    It contains built versions of the user guide, corresponding to the
+    framework releases.  
+    It could be downloaded, forked or composer-installed.  
+    This is a read-only repository.
+
+-   **coding-standard** is the coding style standards repository.  
+    It contains PHP CodeSniffer rules to ensure consistent code style
+    within the framework itself.  
+    It is meant to be composer-installed.
+-   **translations** is the repository holding official translations of
+    the locale-dependent system messages.  
+    It is community-maintained, and accepts issues and pull requests.  
+    It could be downloaded, forked or composer-installed.
+
+##Contributor Scripts
+
+-   **setup.sh** installs a git pre-commit hook into a contributor's
+    local clone of their fork of the `CodeIgniter4` repository.
+-   **pre-commit** runs PHP Lint and PHP CodeSniffer on any files
+    to be added as part of a git commit, ensuring that they conform to the
+    framework coding style standards, and automatically fixing what can be.
+
+##Maintainer Scripts
+
+-   **docbot** re-builds the user guide from the RST source for it,
+    and optionally deploys it to the `gh-pages` branch of the main
+    repository (if the user running it has maintainer rights on that repo).  
+    See the [writeup](./docbot.md).
+
+##Release Building Scripts
+
+The release workflow is detailed in its own writeup; these are the main
+scripts used by the release manager:
+
+-   **pre-release** builds a new release branch in the main repo, for vetting.  
+    This includes updating version dependencies or constants,
+    generating version(s) of the user guide; and possibly
+    moving or ignoring stuff, distinguishing release from development.
+    If successful, it will leave a `releasing` file, with the version number
+    in it.
+-   **release** builds release branches for the derived repositories
+    (framework, appstarter and userguide).  
+    These are pushed to the respective repositories (if the user has maintainer
+    rights), but the actual associated releases are created on github.com manually, so 
+    that additional binaries can be added to the release if appropriate.
+-   **post-release** cleans up after a release, eg. setting up the changelog for
+    the next release.
+
+
+##Other Stuff
+
+-   **release-notes.bb** is a boilerplate for forum announcements of a new release.  
+    It is marked up using [BBcode](https://en.wikipedia.org/wiki/BBCode).

admin/README.md

@@ -0,0 +1,36 @@
+#!/bin/bash
+
+# Rebuild and deploy CodeIgniter4 user guide
+
+UPSTREAM=https://github.com/codeigniter4/CodeIgniter4.git
+
+# Prepare the nested repo clone folder
+cd user_guide_src
+rm -rf build/*
+mkdir build/html
+
+# Get ready for git
+cd build/html
+git init
+git remote add origin $UPSTREAM
+git fetch 
+git checkout gh-pages
+git reset --hard origin/gh-pages
+rm -r *
+
+# Make the new user guide
+cd ../..
+make html
+
+# All done?
+if [ $# -lt 1 ]; then
+  exit 0
+fi
+
+# Optionally update the remote repo
+if [ $1 = "deploy" ]; then
+  cd build/html
+  git add .
+  git commit -S -m "Docbot synching"
+  git push -f origin gh-pages
+fi

admin/docbot

@@ -0,0 +1,33 @@
+# docbot
+
+Builds & deploys user guide.
+
+The in-progress CI4 user guide, warts & all, is rebuilt in a nested
+repository clone (`user_guide_src/build/html`), with the result
+optionally pushed to the `gh-pages` branch of the repo.
+That would then be publically visible as the in-progress
+version of the [User Guide](https://codeigniter4.github.io/CodeIgniter4/).
+
+## Audience
+
+This script is intended for use by framework maintainers,
+i.e. someone with commit rights on the CI4 repository.
+
+This script wraps the conventional user guide building,
+i.e. `user_guide_src/make html`, with additional
+steps.
+
+You will be prompted for your github credentials and
+GPG-signing key as appropriate.
+
+## Usage
+
+Inside a shell prompt, in the project root:
+
+    `admin/docbot [deploy]`
+
+If "deploy" is not added, the script execution is considered
+a trial run, and nothing is pushed to the repo.
+
+Whether or not deployed, the results are left inside
+user_guide_src/build (which is git ignored).