Skip to content

Commit d53b351

Browse files
committed
clean up test with soft deleted first
1 parent 7d515e5 commit d53b351

1 file changed

Lines changed: 4 additions & 18 deletions

File tree

tests/system/Database/Live/ModelTest.php

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ public function testFirstRespectsSoftDeletes($aggregate, $groupBy)
330330

331331
$user = $model->first();
332332

333-
if (! $aggregate)
333+
if (! $aggregate || $groupBy)
334334
{
335335
// fix for PHP7.2
336336
$count = is_array($user) ? count($user) : 1;
@@ -339,14 +339,7 @@ public function testFirstRespectsSoftDeletes($aggregate, $groupBy)
339339
}
340340
else
341341
{
342-
if ($groupBy)
343-
{
344-
$this->assertEquals(2, $user->id);
345-
}
346-
else
347-
{
348-
$this->assertEquals(9, $user->id);
349-
}
342+
$this->assertEquals(9, $user->id);
350343
}
351344

352345
$user = $model->withDeleted();
@@ -1977,20 +1970,13 @@ public function testFirstRecoverTempUseSoftDeletes($aggregate, $groupBy)
19771970

19781971
$user = $model->withDeleted()->first();
19791972

1980-
if (! $aggregate)
1973+
if (! $aggregate || $groupBy)
19811974
{
19821975
$this->assertEquals(1, $user->id);
19831976
}
19841977
else
19851978
{
1986-
if ($groupBy)
1987-
{
1988-
$this->assertEquals(1, $user->id);
1989-
}
1990-
else
1991-
{
1992-
$this->assertEquals(10, $user->id);
1993-
}
1979+
$this->assertEquals(10, $user->id);
19941980
}
19951981

19961982
$user2 = $model->first();

0 commit comments

Comments
 (0)