fix phpstan

Author: michalsn

system/Common.php

@@ -121,6 +121,7 @@ function clean_path(string $path): string
      *
      * @return false|string
      */
+    // @phpstan-ignore return.unusedType (The executed command may change the output buffer level.)
     function command(string $command)
     {
         $regexString = '([^\s]+?)(?:\s|(?<!\\\\)"|(?<!\\\\)\'|$)';

tests/system/CommonFunctionsSendTest.php

@@ -58,6 +58,7 @@ public function testRedirectResponseCookiesSent(): void
         // send it
         ob_start();
         $response->send();
+        // @phpstan-ignore greater.alwaysTrue (The response may change the output buffer level.)
         if (ob_get_level() > 0) {
             ob_end_clean();
         }

tests/system/HTTP/DownloadResponseTest.php

@@ -377,6 +377,7 @@ public function testRealOutput(): void
         // send it
         ob_start();
         $response->send();
+        // @phpstan-ignore greater.alwaysTrue (The response may change the output buffer level.)
         if (ob_get_level() > 0) {
             ob_end_clean();
         }

tests/system/HTTP/ResponseSendTest.php

@@ -67,6 +67,7 @@ public function testHeadersMissingDate(): void
         // send it
         ob_start();
         $response->send();
+        // @phpstan-ignore greater.alwaysTrue (The response may change the output buffer level.)
         if (ob_get_level() > 0) {
             ob_end_clean();
         }
@@ -102,6 +103,7 @@ public function testHeadersWithCSP(): void
         // send it
         ob_start();
         $response->send();
+        // @phpstan-ignore greater.alwaysTrue (The response may change the output buffer level.)
         if (ob_get_level() > 0) {
             ob_end_clean();
         }
@@ -140,6 +142,7 @@ public function testRedirectResponseCookies(): void
         // send it
         ob_start();
         $response->send();
+        // @phpstan-ignore greater.alwaysTrue (The response may change the output buffer level.)
         if (ob_get_level() > 0) {
             ob_end_clean();
         }
@@ -213,6 +216,7 @@ public function testHeaderOverride(): void
         header('Access-Control-Expose-Headers: Content-Encoding');
         header('Allow: GET, POST');
         $response->send();
+        // @phpstan-ignore greater.alwaysTrue (The response may change the output buffer level.)
         if (ob_get_level() > 0) {
             ob_end_clean();
         }

tests/system/Test/BootstrapFCPATHTest.php

@@ -100,7 +100,7 @@ private function fileContents(): string
         return $fileContents . 'echo FCPATH;' . PHP_EOL;
     }
 
-    private function readOutput(string $file): false|string
+    private function readOutput(string $file): string
     {
         ob_start();
         system('php -f ' . $file);

tests/system/Test/TestCaseEmissionsTest.php

@@ -62,6 +62,7 @@ public function testHeadersEmitted(): void
         // send it
         ob_start();
         $response->send();
+        // @phpstan-ignore greater.alwaysTrue (The response may change the output buffer level.)
         if (ob_get_level() > 0) {
             ob_end_clean();
         }
@@ -90,6 +91,7 @@ public function testHeadersNotEmitted(): void
         // send it
         ob_start();
         $response->send(); // what really was sent
+        // @phpstan-ignore greater.alwaysTrue (The response may change the output buffer level.)
         if (ob_get_level() > 0) {
             ob_end_clean();
         }

utils/phpstan-baseline/loader.neon

@@ -1,4 +1,4 @@
-# total 1825 errors
+# total 1827 errors
 
 includes:
     - argument.type.neon

utils/phpstan-baseline/method.notFound.neon

@@ -1,4 +1,4 @@
-# total 78 errors
+# total 80 errors
 
 parameters:
     ignoreErrors:
@@ -69,7 +69,7 @@ parameters:
 
         -
             message: '#^Call to an undefined method CodeIgniter\\HTTP\\Request\:\:getGetPost\(\)\.$#'
-            count: 5
+            count: 6
             path: ../../tests/system/HTTP/IncomingRequestTest.php
 
         -
@@ -89,7 +89,7 @@ parameters:
 
         -
             message: '#^Call to an undefined method CodeIgniter\\HTTP\\Request\:\:getPostGet\(\)\.$#'
-            count: 5
+            count: 6
             path: ../../tests/system/HTTP/IncomingRequestTest.php
 
         -