refactor: compare it to the return value to make it easier to understand what it is doing

kenjis · paulbalandan · web-flow · commit bb82f4e76035 · 2021-12-07T18:32:51.000+09:00
Co-authored-by: John Paul E. Balandan, CPA &lt;51850998+paulbalandan@users.noreply.github.com&gt;
diff --git a/system/I18n/Time.php b/system/I18n/Time.php
@@ -479,7 +479,7 @@ public function getQuarter(): string
      */
     public function getDst(): bool
     {
-        return (bool) $this->format('I');
+        return $this->format('I') === '1'; // 1 if Daylight Saving Time, 0 otherwise.
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -479,7 +479,7 @@ public function getQuarter(): string`
`479`	`479`	`*/`
`480`	`480`	`public function getDst(): bool`
`481`	`481`	`{`
`482`		`- return (bool) $this->format('I');`
	`482`	`+ return $this->format('I') === '1'; // 1 if Daylight Saving Time, 0 otherwise.`
`483`	`483`	`}`
`484`	`484`
`485`	`485`	`/**`