Some migration runner test fixes

Author: lonnieezell

system/Database/MigrationRunner.php

@@ -258,7 +258,7 @@ public function version(string $targetVersion, string $namespace = null, string
 		$migrationStatus = false;
 		foreach ($migrations as $version => $migration)
 		{
-			// Only include migrations within the scoop
+			// Only include migrations within the scope
 			if (($method === 'up' && $version > $currentVersion && $version <= $targetVersion) || ( $method === 'down' && $version <= $currentVersion && $version > $targetVersion))
 			{
 				$migrationStatus = false;

tests/system/Database/Migrations/MigrationRunnerTest.php

@@ -10,6 +10,8 @@
  */
 class MigrationRunnerTest extends CIDatabaseTestCase
 {
+	protected $refresh = true;
+
 	protected $root;
 	protected $start;
 	protected $config;
@@ -217,15 +219,15 @@ public function testFindMigrationsSuccessOrder()
 	}
 
 	/**
-	 * @expectedException           \CodeIgniter\Exceptions\ConfigException
-	 * @expectedExceptionMessage    Migrations have been loaded but are disabled or setup incorrectly.
+	 * @expectedException        \CodeIgniter\Exceptions\ConfigException
+	 * @expectedExceptionMessage Migrations have been loaded but are disabled or setup incorrectly.
 	 */
 	public function testMigrationThrowsDisabledException()
 	{
-		$config = $this->config;
-		$config->type = 'sequential';
+		$config          = $this->config;
+		$config->type    = 'sequential';
 		$config->enabled = false;
-		$runner = new MigrationRunner($config);
+		$runner          = new MigrationRunner($config);
 
 		$runner->setSilent(false);
 
@@ -262,21 +264,6 @@ public function testVersionThrowsMigrationGapException()
 		$this->assertFalse($version);
 	}
 
-	public function testVersionReturnsFalseWhenNothingToDo()
-	{
-		$config       = $this->config;
-		$config->type = 'sequential';
-		$runner       = new MigrationRunner($config);
-
-		$runner = $runner->setPath($this->start);
-
-		vfsStream::newFile('001_some_migration.php')->at($this->root);
-
-		$version = $runner->version(0);
-
-		$this->assertFalse($version);
-	}
-
 	/**
 	 * @expectedException        \RuntimeException
 	 * @expectedExceptionMessage The migration class "App\Database\Migrations\Migration_some_migration" could not be found.
@@ -292,7 +279,7 @@ public function testVersionWithNoClassInFile()
 
 		vfsStream::newFile('001_some_migration.php')->at($this->root);
 
-		$version = $runner->version(1);
+		$version = $runner->version(0);
 
 		$this->assertFalse($version);
 	}