Merge remote-tracking branch 'upstream/develop' into 4.5

Author: kenjis

system/Database/Postgre/Connection.php

@@ -67,6 +67,9 @@ public function connect(bool $persistent = false)
         }
 
         // Convert DSN string
+        // @TODO This format is for PDO_PGSQL.
+        //      https://www.php.net/manual/en/ref.pdo-pgsql.connection.php
+        //      Should deprecate?
         if (mb_strpos($this->DSN, 'pgsql:') === 0) {
             $this->convertDSN();
         }

tests/system/Database/ConfigTest.php

@@ -200,6 +200,9 @@ public function testConnectionGroupWithDSNPostgreNative(): void
      */
     public function testConvertDSN(string $input, string $expected): void
     {
+        // @TODO This format is for PDO_PGSQL.
+        //      https://www.php.net/manual/en/ref.pdo-pgsql.connection.php
+        //      Should deprecate?
         $this->dsnGroupPostgreNative['DSN'] = $input;
         $conn                               = Config::connect($this->dsnGroupPostgreNative, false);
         $this->assertInstanceOf(BaseConnection::class, $conn);

user_guide_src/source/concepts/autoloader.rst

@@ -19,8 +19,9 @@ CodeIgniter4 Autoloader
 
 CodeIgniter provides a very flexible autoloader that can be used with very little configuration.
 It can locate individual namespaced classes that adhere to
-`PSR-4 <https://www.php-fig.org/psr/psr-4/>`_ autoloading
-directory structures.
+`PSR-4`_ autoloading directory structures.
+
+.. _PSR-4: https://www.php-fig.org/psr/psr-4/
 
 The autoloader works great by itself, but can also work with other autoloaders, like
 `Composer <https://getcomposer.org>`_, or even your own custom autoloaders, if needed.
@@ -49,16 +50,23 @@ arrays: one for the classmap, and one for PSR-4 compatible namespaces.
 Namespaces
 ==========
 
-The recommended method for organizing your classes is to create one or more namespaces for your
-application's files. This is most important for any business-logic related classes, entity classes,
-etc. The ``$psr4`` array in the configuration file allows you to map the namespace to the directory
+The recommended method for organizing your classes is to create one or more namespaces
+for your application's files.
+
+The ``$psr4`` array in the configuration file allows you to map the namespace to the directory
 those classes can be found in:
 
 .. literalinclude:: autoloader/001.php
 
 The key of each row is the namespace itself. This does not need a trailing back slash.
 The value is the location to the directory the classes can be found in.
 
+By default, the namespace ``App`` is located in the **app** directory, and the
+namespace ``Config`` is located in the ``app/Config`` directory.
+
+If you create class files in the locations and according to `PSR-4`_, the autoloader
+will autoload them.
+
 .. _confirming-namespaces:
 
 Confirming Namespaces
@@ -119,9 +127,8 @@ You will need to modify any existing files that are referencing the current name
 Classmap
 ========
 
-The classmap is used extensively by CodeIgniter to eke the last ounces of performance out of the system
-by not hitting the file-system with extra ``is_file()`` calls. You can use the classmap to link to
-third-party libraries that are not namespaced:
+If you use third-party libraries that are not Composer packages and are not namespaced,
+you can load those classes using the classmap:
 
 .. literalinclude:: autoloader/003.php
 

user_guide_src/source/libraries/time.rst

@@ -7,7 +7,9 @@ extension's features to convert times across timezones and display the output co
 is the ``Time`` class and lives in the ``CodeIgniter\I18n`` namespace.
 
 .. note:: Since the Time class extends ``DateTimeImmutable``, if there are features that you need that this class doesn't provide,
-    you can likely find them within the `DateTimeImmutable <https://www.php.net/manual/en/class.datetimeimmutable.php>`_  class itself.
+    you can likely find them within the `DateTimeImmutable`_  class itself.
+
+.. _DateTimeImmutable: https://www.php.net/manual/en/class.datetimeimmutable.php
 
 .. note:: Prior to v4.3.0, the Time class extended ``DateTime`` and some inherited methods changed
     the current object state. The bug was fixed in v4.3.0. If you need the old Time class for backward
@@ -24,10 +26,11 @@ Instantiating
 There are several ways that a new Time instance can be created. The first is simply to create a new instance
 like any other class.
 
-When you do it this way, you can pass in a string representing the desired time. This can
-be any string that PHP's `strtotime()`_ function can parse:
+When you do it this way, you can pass in a string representing the desired time.
+This can be any string that PHP's `DateTimeImmutable`_ constructor can parse. See
+`Supported Date and Time Formats`_ for details.
 
-.. _strtotime(): https://www.php.net/manual/en/function.strtotime.php
+.. _Supported Date and Time Formats: https://www.php.net/manual/en/datetime.formats.php
 
 .. literalinclude:: time/001.php
 

user_guide_src/source/libraries/time/001.php

@@ -2,5 +2,7 @@
 
 use CodeIgniter\I18n\Time;
 
-$myTime = new Time('+3 week');
+$myTime = new Time('2024-01-01');
+$myTime = new Time('2024-01-01 12:00:00');
 $myTime = new Time('now');
+$myTime = new Time('+3 week');