Resolve session save handler issue

jim-parry · jim-parry · commit 933043ce64e2 · 2019-10-06T17:17:24.000-07:00
diff --git a/system/Session/Handlers/FileHandler.php b/system/Session/Handlers/FileHandler.php
@@ -187,7 +187,7 @@ public function read($sessionID): string
 			}
 
 			// Needed by write() to detect session_regenerate_id() calls
-			if(is_null($this->sessionID))
+			if (is_null($this->sessionID))
 			{
 				$this->sessionID = $sessionID;
 			}
@@ -206,6 +206,7 @@ public function read($sessionID): string
 		}
 
 		$session_data = '';
+		clearstatcache();    // Address https://github.com/codeigniter4/CodeIgniter4/issues/2056
 		for ($read = 0, $length = filesize($this->filePath . $sessionID); $read < $length; $read += strlen($buffer))
 		{
 			if (($buffer = fread($this->fileHandle, $length - $read)) === false)

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ public function read($sessionID): string`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`// Needed by write() to detect session_regenerate_id() calls`
`190`		`- if(is_null($this->sessionID))`
	`190`	`+ if (is_null($this->sessionID))`
`191`	`191`	`{`
`192`	`192`	`$this->sessionID = $sessionID;`
`193`	`193`	`}`
`@@ -206,6 +206,7 @@ public function read($sessionID): string`
`206`	`206`	`}`
`207`	`207`
`208`	`208`	`$session_data = '';`
	`209`	`+ clearstatcache(); // Address https://github.com/codeigniter4/CodeIgniter4/issues/2056`
`209`	`210`	`for ($read = 0, $length = filesize($this->filePath . $sessionID); $read < $length; $read += strlen($buffer))`
`210`	`211`	`{`
`211`	`212`	`if (($buffer = fread($this->fileHandle, $length - $read)) === false)`