Add tests for PR #2847

Author: paulbalandan

system/Test/bootstrap.php

@@ -16,12 +16,14 @@
 defined('APPPATH')       || define('APPPATH', realpath($paths->appDirectory) . DIRECTORY_SEPARATOR);
 defined('WRITEPATH')     || define('WRITEPATH', realpath($paths->writableDirectory) . DIRECTORY_SEPARATOR);
 defined('SYSTEMPATH')    || define('SYSTEMPATH', realpath($paths->systemDirectory) . DIRECTORY_SEPARATOR);
+defined('VIEWPATH')      || define('VIEWPATH', realpath($paths->viewDirectory) . DIRECTORY_SEPARATOR);
 defined('ROOTPATH')      || define('ROOTPATH', realpath(APPPATH . '../') . DIRECTORY_SEPARATOR);
 defined('CIPATH')        || define('CIPATH', realpath(SYSTEMPATH . '../') . DIRECTORY_SEPARATOR);
 defined('FCPATH')        || define('FCPATH', realpath(PUBLICPATH) . DIRECTORY_SEPARATOR);
 defined('TESTPATH')      || define('TESTPATH', realpath(HOMEPATH . 'tests/') . DIRECTORY_SEPARATOR);
 defined('SUPPORTPATH')   || define('SUPPORTPATH', realpath(TESTPATH . '_support/') . DIRECTORY_SEPARATOR);
 defined('COMPOSER_PATH') || define('COMPOSER_PATH', realpath(HOMEPATH . 'vendor/autoload.php'));
+defined('VENDORPATH')    || define('VENDORPATH', realpath(HOMEPATH . 'vendor') . DIRECTORY_SEPARATOR);
 
 // Load Common.php from App then System
 if (file_exists(APPPATH . 'Common.php'))

tests/system/Debug/ExceptionsTest.php

@@ -7,4 +7,26 @@ public function testNew()
 		$actual = new Exceptions(new \Config\Exceptions(), \Config\Services::request(), \Config\Services::response());
 		$this->assertInstanceOf(Exceptions::class, $actual);
 	}
+
+	/**
+	 * @dataProvider dirtyPathsProvider
+	 */
+	public function testCleanPaths($file, $expected)
+	{
+		$this->assertEquals($expected, Exceptions::cleanPath($file));
+	}
+
+	public function dirtyPathsProvider()
+	{
+		$ds = DIRECTORY_SEPARATOR;
+
+		return [
+			[APPPATH . 'Config' . $ds . 'App.php', 'APPPATH' . $ds . 'Config' . $ds . 'App.php'],
+			[APPPATH . 'Views' . $ds . 'welcome_message.php', 'VIEWPATH' . $ds . 'welcome_message.php'],
+			[SYSTEMPATH . 'CodeIgniter.php', 'SYSTEMPATH' . $ds . 'CodeIgniter.php'],
+			[VIEWPATH . 'errors' . $ds . 'html' . $ds . 'error_exception.php', 'VIEWPATH' . $ds . 'errors' . $ds . 'html' . $ds . 'error_exception.php'],
+			[VENDORPATH . 'autoload.php', 'VENDORPATH' . $ds . 'autoload.php'],
+			[FCPATH . 'index.php', 'FCPATH' . $ds . 'index.php'],
+		];
+	}
 }