Merge pull request #4743 from samsonasik/rector-list-to-aray-destruct

[Rector] Apply Rector : ListToArrayDestructRector

Author: samsonasik

rector.php

@@ -23,6 +23,7 @@
 use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
 use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
 use Rector\Php70\Rector\Ternary\TernaryToNullCoalescingRector;
+use Rector\Php71\Rector\List_\ListToArrayDestructRector;
 use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
 use Rector\Php73\Rector\FuncCall\StringifyStrNeedlesRector;
 use Rector\Set\ValueObject\SetList;
@@ -88,4 +89,5 @@
 	$services->set(RemoveUnusedPrivatePropertyRector::class);
 	$services->set(RemoveErrorSuppressInTryCatchStmtsRector::class);
 	$services->set(TernaryToNullCoalescingRector::class);
+	$services->set(ListToArrayDestructRector::class);
 };

system/Cache/Handlers/MemcachedHandler.php

@@ -351,7 +351,7 @@ public function getMetaData(string $key)
 			return false; // This will return null in a future release
 		}
 
-		list($data, $time, $limit) = $stored;
+		[$data, $time, $limit] = $stored;
 
 		// Calculate the remaining time to live from the original limit
 		$ttl = time() - $time - $limit;

system/Config/DotEnv.php

@@ -90,7 +90,7 @@ public function parse(): ?array
 			// If there is an equal sign, then we know we are assigning a variable.
 			if (strpos($line, '=') !== false)
 			{
-				list($name, $value) = $this->normaliseVariable($line);
+				[$name, $value] = $this->normaliseVariable($line);
 				$vars[$name]        = $value;
 				$this->setVariable($name, $value);
 			}
@@ -143,7 +143,7 @@ public function normaliseVariable(string $name, string $value = ''): array
 		// Split our compound string into its parts.
 		if (strpos($name, '=') !== false)
 		{
-			list($name, $value) = explode('=', $name, 2);
+			[$name, $value] = explode('=', $name, 2);
 		}
 
 		$name  = trim($name);

system/Cookie/Cookie.php

@@ -184,7 +184,7 @@ public static function fromHeaderString(string $cookie, bool $raw = false)
 		{
 			if (strpos($part, '=') !== false)
 			{
-				list($attr, $val) = explode('=', $part);
+				[$attr, $val] = explode('=', $part);
 			}
 			else
 			{

system/Filters/Filters.php

@@ -358,7 +358,7 @@ public function enableFilter(string $name, string $when = 'before')
 		// Get parameters and clean name
 		if (strpos($name, ':') !== false)
 		{
-			list($name, $params) = explode(':', $name);
+			[$name, $params] = explode(':', $name);
 
 			$params = explode(',', $params);
 			array_walk($params, function (&$item) {

system/HTTP/Negotiate.php

@@ -391,8 +391,8 @@ public function matchTypes(array $acceptable, array $supported): bool
 	{
 		// PHPDocumentor v2 cannot parse yet the shorter list syntax,
 		// causing no API generation for the file.
-		list($aType, $aSubType) = explode('/', $acceptable['value']);
-		list($sType, $sSubType) = explode('/', $supported['value']);
+		[$aType, $aSubType] = explode('/', $acceptable['value']);
+		[$sType, $sSubType] = explode('/', $supported['value']);
 
 		// If the types don't match, we're done.
 		if ($aType !== $sType)

system/I18n/Time.php

@@ -758,7 +758,7 @@ public function setSecond($value)
 	 */
 	protected function setValue(string $name, $value)
 	{
-		list($year, $month, $day, $hour, $minute, $second) = explode('-', $this->format('Y-n-j-G-i-s'));
+		[$year, $month, $day, $hour, $minute, $second] = explode('-', $this->format('Y-n-j-G-i-s'));
 		$$name                                             = $value;
 
 		return Time::create(

system/Images/Handlers/BaseHandler.php

@@ -638,14 +638,14 @@ public function fit(int $width, int $height = null, string $position = 'center')
 		$origWidth  = $this->image()->origWidth;
 		$origHeight = $this->image()->origHeight;
 
-		list($cropWidth, $cropHeight) = $this->calcAspectRatio($width, $height, $origWidth, $origHeight);
+		[$cropWidth, $cropHeight] = $this->calcAspectRatio($width, $height, $origWidth, $origHeight);
 
 		if (is_null($height))
 		{
 			$height = ceil(($width / $cropWidth) * $cropHeight);
 		}
 
-		list($x, $y) = $this->calcCropCoords($cropWidth, $cropHeight, $origWidth, $origHeight, $position);
+		[$x, $y] = $this->calcCropCoords($cropWidth, $cropHeight, $origWidth, $origHeight, $position);
 
 		return $this->crop($cropWidth, $cropHeight, $x, $y)
 						->resize($width, $height);

system/Images/Handlers/ImageMagickHandler.php

@@ -450,7 +450,7 @@ protected function _text(string $text, array $options = [])
 		// Color
 		if (isset($options['color']))
 		{
-			list($r, $g, $b) = sscanf("#{$options['color']}", '#%02x%02x%02x');
+			[$r, $g, $b] = sscanf("#{$options['color']}", '#%02x%02x%02x');
 
 			$cmd .= " -fill 'rgba({$r},{$g},{$b},{$options['opacity']})'";
 		}

system/Language/Language.php

@@ -115,23 +115,23 @@ public function getLine(string $line, array $args = [])
 
 		// Parse out the file name and the actual alias.
 		// Will load the language file and strings.
-		list($file, $parsedLine) = $this->parseLine($line, $this->locale);
+		[$file, $parsedLine] = $this->parseLine($line, $this->locale);
 
 		$output = $this->getTranslationOutput($this->locale, $file, $parsedLine);
 
 		if ($output === null && strpos($this->locale, '-'))
 		{
-			list($locale) = explode('-', $this->locale, 2);
+			[$locale] = explode('-', $this->locale, 2);
 
-			list($file, $parsedLine) = $this->parseLine($line, $locale);
+			[$file, $parsedLine] = $this->parseLine($line, $locale);
 
 			$output = $this->getTranslationOutput($locale, $file, $parsedLine);
 		}
 
 		// if still not found, try English
 		if ($output === null)
 		{
-			list($file, $parsedLine) = $this->parseLine($line, 'en');
+			[$file, $parsedLine] = $this->parseLine($line, 'en');
 
 			$output = $this->getTranslationOutput('en', $file, $parsedLine);
 		}