Filters match case-insensitively. Fixes #1664

Author: lonnieezell

system/Filters/Filters.php

@@ -119,7 +119,7 @@ public function setResponse(ResponseInterface $response)
 	 */
 	public function run(string $uri, $position = 'before')
 	{
-		$this->initialize($uri);
+		$this->initialize(strtolower($uri));
 
 		foreach ($this->filters[$position] as $alias => $rules)
 		{
@@ -350,7 +350,7 @@ protected function processGlobals(string $uri = null)
 				foreach ($rules as $path)
 				{
 					// Prep it for regex
-					$path = str_replace('/*', '*', $path);
+					$path = strtolower(str_replace('/*', '*', $path));
 					$path = trim(str_replace('*', '.+', $path), '/ ');
 
 					// Path doesn't match the URI? continue on...
@@ -388,7 +388,7 @@ protected function processGlobals(string $uri = null)
 				foreach ($rules as $path)
 				{
 					// Prep it for regex
-					$path = str_replace('/*', '*', $path);
+					$path = strtolower(str_replace('/*', '*', $path));
 					$path = trim(str_replace('*', '.+', $path), '/ ');
 
 					// Path doesn't match the URI? continue on...
@@ -434,7 +434,7 @@ protected function processFilters(string $uri = null)
 			return;
 		}
 
-		$uri = trim($uri, '/ ');
+		$uri = strtolower(trim($uri, '/ '));
 
 		$matches = [];
 
@@ -446,7 +446,7 @@ protected function processFilters(string $uri = null)
 				foreach ($settings['before'] as $path)
 				{
 					// Prep it for regex
-					$path = str_replace('/*', '*', $path);
+					$path = strtolower(str_replace('/*', '*', $path));
 					$path = trim(str_replace('*', '.+', $path), '/ ');
 
 					if (preg_match('#' . $path . '#', $uri) !== 1)
@@ -467,7 +467,7 @@ protected function processFilters(string $uri = null)
 				foreach ($settings['after'] as $path)
 				{
 					// Prep it for regex
-					$path = str_replace('/*', '*', $path);
+					$path = strtolower(str_replace('/*', '*', $path));
 					$path = trim(str_replace('*', '.+', $path), '/ ');
 
 					if (preg_match('#' . $path . '#', $uri) !== 1)

tests/system/Filters/FiltersTest.php

@@ -637,4 +637,46 @@ public function testEnableNonFilter()
 		$filters->enableFilter('goggle', 'before');
 	}
 
+	/**
+	 * @see https://github.com/codeigniter4/CodeIgniter4/issues/1664
+	 */
+	public function testMatchesURICaseInsensitively()
+	{
+		$_SERVER['REQUEST_METHOD'] = 'GET';
+
+		$config  = [
+			'globals' => [
+				'before' => [
+					'foo' => ['except' => 'Admin/*'],
+					'bar'
+				],
+				'after'  => [
+					'foo' => ['except' => 'Admin/*'],
+					'baz'
+				],
+			],
+			'filters' => [
+				'frak' => [
+					'before' => ['Admin/*'],
+					'after'  => ['Admin/*'],
+				],
+			],
+		];
+		$filters = new Filters((object) $config, $this->request, $this->response);
+		$uri     = 'admin/foo/bar';
+
+		$expected = [
+			'before' => [
+				'bar',
+				'frak',
+			],
+			'after'  => [
+				'baz',
+				'frak',
+			],
+		];
+
+		$this->assertEquals($expected, $filters->initialize($uri)->getFilters());
+	}
+
 }