Merge pull request #2164 from MGatner/cli-returns

Exit error code on CLI Command failure

Author: lonnieezell

spark

@@ -53,5 +53,9 @@ ini_set('display_errors', 1);
 // Show basic information before we do anything else.
 $console->showHeader();
 
-// fire off the command the main framework.
-$console->run();
+// fire off the command in the main framework.
+$response = $console->run();
+if ($response->getStatusCode() >= 300)
+{
+	exit($response->getStatusCode());
+}

system/CLI/CommandRunner.php

@@ -71,6 +71,7 @@ class CommandRunner extends Controller
 	 * @param string $method
 	 * @param array  ...$params
 	 *
+	 * @return mixed
 	 * @throws \ReflectionException
 	 */
 	public function _remap($method, ...$params)
@@ -81,7 +82,7 @@ public function _remap($method, ...$params)
 			array_shift($params);
 		}
 
-		$this->index($params);
+		return $this->index($params);
 	}
 
 	//--------------------------------------------------------------------

system/CodeIgniter.php

@@ -355,6 +355,12 @@ protected function handleRequest(RouteCollectionInterface $routes = null, $cache
 		else
 		{
 			$response = $this->response;
+			
+			// Set response code for CLI command failures
+			if (is_numeric($returned) || $returned === false)
+			{
+				$response->setStatusCode(400);
+			}
 		}
 
 		if ($response instanceof Response)