Skip to content

Commit 68ce1b2

Browse files
authored
Update BaseBuilder.php
Is it breaks anything or will repair having('MAX(sth)', null, false) before: ``` SELECT `aht_cur_id_2` `cur_id_2`, `aht_cur_id_1` `cur_id_1`, `aht_rate` `rate` FROM `t_api_trading_trades` GROUP BY `aht_cur_id_2`, `aht_cur_id_1` HAVING MAX(aht_api_trade_id) = NULL ``` now: ``` SELECT `aht_cur_id_2` `cur_id_2`, `aht_cur_id_1` `cur_id_1`, `aht_rate` `rate` FROM `t_api_trading_trades` GROUP BY `aht_cur_id_2`, `aht_cur_id_1` HAVING MAX(aht_api_trade_id) ```
1 parent d494df9 commit 68ce1b2

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

system/Database/BaseBuilder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -706,7 +706,7 @@ protected function whereHaving(string $qb_key, $key, $value = null, string $type
706706

707707
$v = " :$bind:";
708708
}
709-
elseif (! $this->hasOperator($k))
709+
elseif (! $this->hasOperator($k) && $qb_key !== 'QBHaving')
710710
{
711711
// value appears not to have been set, assign the test to IS NULL
712712
$k .= ' IS NULL';

0 commit comments

Comments
 (0)