Merge pull request #1507 from samsonasik/valid-emails

Fix multi "empty" string separated by "," marked as valid emails

Author: jim-parry

system/Validation/FormatRules.php

@@ -294,7 +294,13 @@ public function valid_emails(string $str = null): bool
 
 		foreach (explode(',', $str) as $email)
 		{
-			if (trim($email) !== '' && $this->valid_email(trim($email)) === false)
+			$email = trim($email);
+			if ($email === '')
+			{
+				return false;
+			}
+
+			if ($this->valid_email($email) === false)
 			{
 				return false;
 			}

tests/system/Validation/FormatRulesTest.php

@@ -241,6 +241,10 @@ public function emailsProvider()
 				null,
 				false,
 			],
+			[
+				',',
+				false,
+			],
 		];
 	}