Skip to content

Commit 5eef935

Browse files
committed
Safer to use ->sub when subtracting dates instead of adding negative numbers.
1 parent 0cac222 commit 5eef935

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

system/I18n/Time.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -839,7 +839,7 @@ public function subSeconds(int $seconds)
839839
{
840840
$time = clone($this);
841841

842-
return $time->add(DateInterval::createFromDateString("-{$seconds} seconds"));
842+
return $time->sub(DateInterval::createFromDateString("{$seconds} seconds"));
843843
}
844844

845845
/**
@@ -853,7 +853,7 @@ public function subMinutes(int $minutes)
853853
{
854854
$time = clone($this);
855855

856-
return $time->add(DateInterval::createFromDateString("-{$minutes} minutes"));
856+
return $time->sub(DateInterval::createFromDateString("{$minutes} minutes"));
857857
}
858858

859859
/**
@@ -867,7 +867,7 @@ public function subHours(int $hours)
867867
{
868868
$time = clone($this);
869869

870-
return $time->add(DateInterval::createFromDateString("-{$hours} hours"));
870+
return $time->sub(DateInterval::createFromDateString("{$hours} hours"));
871871
}
872872

873873
/**
@@ -881,7 +881,7 @@ public function subDays(int $days)
881881
{
882882
$time = clone($this);
883883

884-
return $time->add(DateInterval::createFromDateString("-{$days} days"));
884+
return $time->sub(DateInterval::createFromDateString("{$days} days"));
885885
}
886886

887887
/**
@@ -895,7 +895,7 @@ public function subMonths(int $months)
895895
{
896896
$time = clone($this);
897897

898-
return $time->add(DateInterval::createFromDateString("-{$months} months"));
898+
return $time->sub(DateInterval::createFromDateString("{$months} months"));
899899
}
900900

901901
/**
@@ -909,7 +909,7 @@ public function subYears(int $years)
909909
{
910910
$time = clone($this);
911911

912-
return $time->add(DateInterval::createFromDateString("-{$years} years"));
912+
return $time->sub(DateInterval::createFromDateString("{$years} years"));
913913
}
914914

915915
//--------------------------------------------------------------------

0 commit comments

Comments
 (0)