Merge pull request #2655 from MashinaMashina/patch-1

lonnieezell · web-flow · commit 5093694d5c8a · 2020-03-09T08:57:41.000-05:00
Fix JSON error on recursion in data
diff --git a/system/Format/JSONFormatter.php b/system/Format/JSONFormatter.php
@@ -56,13 +56,13 @@ class JSONFormatter implements FormatterInterface
 	 */
 	public function format($data)
 	{
-		$options = JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES;
+		$options = JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES | JSON_PARTIAL_OUTPUT_ON_ERROR;
 
 		$options = ENVIRONMENT === 'production' ? $options : $options | JSON_PRETTY_PRINT;
 
 		$result = json_encode($data, $options, 512);
 
-		if (json_last_error() !== JSON_ERROR_NONE)
+		if ( ! in_array(json_last_error(), [JSON_ERROR_NONE, JSON_ERROR_RECURSION]))
 		{
 			throw FormatException::forInvalidJSON(json_last_error_msg());
 		}

Original file line number	Diff line number	Diff line change
`@@ -56,13 +56,13 @@ class JSONFormatter implements FormatterInterface`
`56`	`56`	`*/`
`57`	`57`	`public function format($data)`
`58`	`58`	`{`
`59`		`- $options = JSON_UNESCAPED_UNICODE \| JSON_UNESCAPED_SLASHES;`
	`59`	`+ $options = JSON_UNESCAPED_UNICODE \| JSON_UNESCAPED_SLASHES \| JSON_PARTIAL_OUTPUT_ON_ERROR;`
`60`	`60`
`61`	`61`	`$options = ENVIRONMENT === 'production' ? $options : $options \| JSON_PRETTY_PRINT;`
`62`	`62`
`63`	`63`	`$result = json_encode($data, $options, 512);`
`64`	`64`
`65`		`- if (json_last_error() !== JSON_ERROR_NONE)`
	`65`	`+ if ( ! in_array(json_last_error(), [JSON_ERROR_NONE, JSON_ERROR_RECURSION]))`
`66`	`66`	`{`
`67`	`67`	`throw FormatException::forInvalidJSON(json_last_error_msg());`
`68`	`68`	`}`