Add tests for magic __isset methods

Author: MGatner

tests/system/Commands/CommandClassTest.php

@@ -0,0 +1,46 @@
+<?php
+namespace CodeIgniter\Commands;
+
+use Config\Services;
+use CodeIgniter\CLI\CommandRunner;
+
+class BaseCommandTest extends \CIUnitTestCase
+{
+	protected $logger;
+	protected $runner;
+
+	protected function setUp()
+	{
+		parent::setUp();
+		$this->logger   = Services::logger();
+		$this->runner   = new CommandRunner();
+	}
+
+	public function testMagicIssetTrue()
+	{
+		$command = new \Tests\Support\Commands\AppInfo($this->logger, $this->runner);
+
+		$this->assertTrue(isset($command->group));
+	}
+
+	public function testMagicIssetFalse()
+	{
+		$command = new \Tests\Support\Commands\AppInfo($this->logger, $this->runner);
+
+		$this->assertFalse(isset($command->foobar));
+	}
+
+	public function testMagicGet()
+	{
+		$command = new \Tests\Support\Commands\AppInfo($this->logger, $this->runner);
+
+		$this->assertEquals('demo', $command->group);
+	}
+
+	public function testMagicGetMissing()
+	{
+		$command = new \Tests\Support\Commands\AppInfo($this->logger, $this->runner);
+
+		$this->assertNull($command->foobar);
+	}
+}

tests/system/Database/BaseConnectionTest.php

@@ -128,4 +128,40 @@ public function testStoresConnectionTimings()
 		$this->assertGreaterThan($start, $db->getConnectStart());
 		$this->assertGreaterThan(0.0, $db->getConnectDuration());
 	}
+
+	//--------------------------------------------------------------------
+
+	public function testMagicIssetTrue()
+	{
+		$db = new MockConnection($this->options);
+
+		$this->assertTrue(isset($db->charset));
+	}
+
+	//--------------------------------------------------------------------
+
+	public function testMagicIssetFalse()
+	{
+		$db = new MockConnection($this->options);
+
+		$this->assertFalse(isset($db->foobar));
+	}
+
+	//--------------------------------------------------------------------
+
+	public function testMagicGet()
+	{
+		$db = new MockConnection($this->options);
+
+		$this->assertEquals('utf8', $db->charset);
+	}
+
+	//--------------------------------------------------------------------
+
+	public function testMagicGetMissing()
+	{
+		$db = new MockConnection($this->options);
+
+		$this->assertNull($db->foobar);
+	}
 }

tests/system/Encryption/EncryptionTest.php

@@ -78,11 +78,6 @@ public function testKeyCreation()
 		$this->assertEquals(16, strlen($this->encryption->createKey(16)));
 	}
 
-	public function testBogusProperty()
-	{
-		$this->assertNull($this->encryption->bogus);
-	}
-
 	// --------------------------------------------------------------------
 
 	public function testServiceSuccess()
@@ -129,4 +124,26 @@ public function testServiceShared()
 		$this->assertEquals('anything', $encrypter->key);
 	}
 
+	//--------------------------------------------------------------------
+
+	public function testMagicIssetTrue()
+	{
+		$this->assertTrue(isset($this->encryption->digest));
+	}
+
+	public function testMagicIssetFalse()
+	{
+		$this->assertFalse(isset($this->encryption->bogus));
+	}
+
+	public function testMagicGet()
+	{
+		$this->assertEquals('SHA512', $this->encryption->digest);
+	}
+
+	public function testMagicGetMissing()
+	{
+		$this->assertNull($this->encryption->bogus);
+	}
+
 }

tests/system/I18n/TimeDifferenceTest.php

@@ -200,4 +200,21 @@ public function testGetter()
 		$this->assertNull($diff->nonsense);
 	}
 
+	public function testMagicIssetTrue()
+	{
+		$current = Time::parse('March 10, 2017', 'America/Chicago');
+		$diff    = $current->difference('March 18, 2017', 'America/Chicago');
+
+		$this->assertTrue(isset($diff->days));
+		$this->assertFalse(isset($diff->nonsense));
+	}
+
+	public function testMagicIssetFalse()
+	{
+		$current = Time::parse('March 10, 2017', 'America/Chicago');
+		$diff    = $current->difference('March 18, 2017', 'America/Chicago');
+
+		$this->assertFalse(isset($diff->nonsense));
+	}
+
 }

tests/system/I18n/TimeTest.php

@@ -221,6 +221,22 @@ public function testTestNow()
 
 	//--------------------------------------------------------------------
 
+	public function testMagicIssetTrue()
+	{
+		$time = Time::parse('January 1, 2016');
+
+		$this->assertTrue(isset($time->year));
+	}
+
+	public function testMagicIssetFalse()
+	{
+		$time = Time::parse('January 1, 2016');
+
+		$this->assertFalse(isset($time->foobar));
+	}
+
+	//--------------------------------------------------------------------
+
 	public function testGetYear()
 	{
 		$time = Time::parse('January 1, 2016');

tests/system/Session/SessionTest.php

@@ -185,6 +185,26 @@ public function testHasReturnsFalseOnNotFound()
 		$this->assertFalse($session->has('bar'));
 	}
 
+	public function testIssetReturnsTrueOnSuccess()
+	{
+		$session = $this->getInstance();
+		$session->start();
+
+		$_SESSION['foo'] = 'bar';
+
+		$this->assertTrue(isset($session->foo));
+	}
+
+	public function testIssetReturnsFalseOnNotFound()
+	{
+		$session = $this->getInstance();
+		$session->start();
+
+		$_SESSION['foo'] = 'bar';
+
+		$this->assertFalse(isset($session->bar));
+	}
+
 	public function testPushNewValueIntoArraySessionValue()
 	{
 		$session = $this->getInstance();