use data provider for group by aggregate first

Author: samsonasik

tests/system/Database/Live/ModelTest.php

@@ -251,39 +251,40 @@ public function testFirst()
 
 	//--------------------------------------------------------------------
 
-	public function testFirstWithoutGroupBy()
+	public function provideGroupBy()
 	{
-		$model = new UserModel();
-
-		$user = $model->select('SUM(id) as total')
-					  ->where('id >', 2)
-					  ->first();
-		$this->assertEquals(7, $user->total);
+		return [
+			[true],
+			[false],
+		];
 	}
 
-	//--------------------------------------------------------------------
-
-	public function testFirstWithGroupBy()
+	/**
+	 * @dataProvider provideGroupBy
+	 */
+	public function testFirstAggregate($groupBy)
 	{
 		$model = new UserModel();
 
-		$user = $model->select('SUM(id) as total')
+		if ($groupBy)
+		{
+			$user = $model->select('SUM(id) as total')
 						->where('id >', 2)
 						->groupBy('id')
 						->first();
-		$this->assertEquals(3, $user->total);
+			$this->assertEquals(3, $user->total);
+		}
+		else
+		{
+			$user = $model->select('SUM(id) as total')
+						->where('id >', 2)
+						->first();
+			$this->assertEquals(7, $user->total);
+		}
 	}
 
 	//--------------------------------------------------------------------
 
-	public function provideGroupBy()
-	{
-		return [
-			[true],
-			[false],
-		];
-	}
-
 	/**
 	 * @dataProvider provideGroupBy
 	 */