add handle is_really_writable() early in __construct

Author: samsonasik

system/Cache/Exceptions/CacheException.php

@@ -2,6 +2,14 @@
 
 class CacheException extends \RuntimeException implements ExceptionInterface
 {
+	/**
+	 * @return \CodeIgniter\Cache\Exceptions\CacheException
+	 */
+	public static function forUnableToWrite(string $path)
+	{
+		return new static(lang('Cache.unableToWrite', [$path]));
+	}
+
 	/**
 	 * @return \CodeIgniter\Cache\Exceptions\CacheException
 	 */

system/Cache/Handlers/FileHandler.php

@@ -37,6 +37,7 @@
  */
 
 use CodeIgniter\Cache\CacheInterface;
+use CodeIgniter\Cache\Exceptions\CacheException;
 
 class FileHandler implements CacheInterface
 {
@@ -59,10 +60,14 @@ class FileHandler implements CacheInterface
 
 	public function __construct($config)
 	{
-		$this->prefix = $config->prefix ?: '';
-		$this->path   = ! empty($config->storePath) ? $config->storePath : WRITEPATH . 'cache';
+		$path = ! empty($config->storePath) ? $config->storePath : WRITEPATH . 'cache';
+		if (! is_really_writable($path))
+		{
+			throw CacheException::forUnableToWrite($path);
+		}
 
-		$this->path = rtrim($this->path, '/') . '/';
+		$this->prefix = $config->prefix ?: '';
+		$this->path   = rtrim($path, '/') . '/';
 	}
 
 	//--------------------------------------------------------------------
@@ -329,11 +334,7 @@ protected function getItem(string $key)
 	 */
 	protected function writeFile($path, $data, $mode = 'wb')
 	{
-		if (($fp = @fopen($path, $mode)) === false)
-		{
-			return false;
-		}
-
+		fopen($path, $mode);
 		flock($fp, LOCK_EX);
 
 		for ($result = $written = 0, $length = strlen($data); $written < $length; $written += $result)

system/Language/en/Cache.php

@@ -15,6 +15,7 @@
  */
 
 return [
+   'unableToWrite'   => 'Cache unable to write to {0}',
    'invalidHandlers' => 'Cache config must have an array of $validHandlers.',
    'noBackup'        => 'Cache config must have a handler and backupHandler set.',
    'handlerNotFound' => 'Cache config has an invalid handler or backup handler specified.',