Skip to content

Commit 2eb123c

Browse files
committed
No more mocks here!
1 parent 7e9b496 commit 2eb123c

8 files changed

Lines changed: 17 additions & 20 deletions

File tree

tests/system/CodeIgniterTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
use Config\App;
44
use Tests\Support\MockCodeIgniter;
55
use CodeIgniter\Router\RouteCollection;
6-
use Tests\Support\Autoloader\MockFileLocator;
6+
use \CodeIgniter\Config\Services;
77

88
/**
99
* @backupGlobals enabled
@@ -135,7 +135,7 @@ public function testRun404OverrideByClosure()
135135
$_SERVER['argc'] = 2;
136136

137137
// Inject mock router.
138-
$routes = new RouteCollection(new MockFileLocator(new \Config\Autoload()), new \Config\Modules());
138+
$routes = new RouteCollection(Services::locator(), new \Config\Modules());
139139
$routes->setAutoRoute(false);
140140
$routes->set404Override(function () {
141141
echo '404 Override by Closure.';

tests/system/CommonFunctionsTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,12 @@
33
use CodeIgniter\Session\Handlers\FileHandler;
44
use CodeIgniter\HTTP\Response;
55
use Config\App;
6-
use Config\Autoload;
76
use CodeIgniter\Config\Services;
87
use CodeIgniter\Router\RouteCollection;
98
use CodeIgniter\HTTP\RedirectResponse;
109
use CodeIgniter\HTTP\URI;
1110
use CodeIgniter\HTTP\UserAgent;
1211
use Config\Logger;
13-
use Tests\Support\Autoloader\MockFileLocator;
1412
use Tests\Support\HTTP\MockIncomingRequest;
1513
use Tests\Support\Log\TestLogger;
1614
use Tests\Support\Session\MockSession;
@@ -102,7 +100,9 @@ public function testRedirectReturnsRedirectResponse()
102100
$_SERVER['REQUEST_METHOD'] = 'GET';
103101

104102
$response = $this->createMock(\CodeIgniter\HTTP\Response::class);
105-
$routes = new \CodeIgniter\Router\RouteCollection(new \Tests\Support\Autoloader\MockFileLocator(new \Config\Autoload()), new \Config\Modules());
103+
$routes = new \CodeIgniter\Router\RouteCollection(
104+
Services::locator(), new \Config\Modules()
105+
);
106106
\CodeIgniter\Services::injectMock('response', $response);
107107
\CodeIgniter\Services::injectMock('routes', $routes);
108108

@@ -267,7 +267,7 @@ public function testOldInput()
267267
$this->config = new App();
268268
$this->config->baseURL = 'http://example.com';
269269

270-
$this->routes = new RouteCollection(new MockFileLocator(new Autoload()), new \Config\Modules());
270+
$this->routes = new RouteCollection(Services::locator(), new \Config\Modules());
271271
Services::injectMock('routes', $this->routes);
272272

273273
$this->request = new MockIncomingRequest($this->config, new URI('http://example.com'), null, new UserAgent());
@@ -303,7 +303,7 @@ public function testOldInputArray()
303303
$this->config = new App();
304304
$this->config->baseURL = 'http://example.com';
305305

306-
$this->routes = new RouteCollection(new MockFileLocator(new Autoload()), new \Config\Modules());
306+
$this->routes = new RouteCollection(Services::locator(), new \Config\Modules());
307307
Services::injectMock('routes', $this->routes);
308308

309309
$this->request = new MockIncomingRequest($this->config, new URI('http://example.com'), null, new UserAgent());

tests/system/HTTP/RedirectResponseTest.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@
33
namespace CodeIgniter\HTTP;
44

55
use Config\App;
6-
use Config\Autoload;
76
use CodeIgniter\Config\Services;
87
use CodeIgniter\Validation\Validation;
98
use CodeIgniter\Router\RouteCollection;
10-
use Tests\Support\Autoloader\MockFileLocator;
119
use Tests\Support\HTTP\MockIncomingRequest;
1210

1311
class RedirectResponseTest extends \CIUnitTestCase
@@ -29,7 +27,7 @@ public function setUp()
2927
$this->config = new App();
3028
$this->config->baseURL = 'http://example.com';
3129

32-
$this->routes = new RouteCollection(new MockFileLocator(new Autoload()), new \Config\Modules());
30+
$this->routes = new RouteCollection(Services::locator(), new \Config\Modules());
3331
Services::injectMock('routes', $this->routes);
3432

3533
$this->request = new MockIncomingRequest($this->config, new URI('http://example.com'), null, new UserAgent());

tests/system/Router/RouteCollectionTest.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
namespace CodeIgniter\Router;
33

4-
use Tests\Support\Autoloader\MockFileLocator;
4+
use CodeIgniter\Config\Services;
55
use CodeIgniter\Router\Exceptions\RouterException;
66

77
/**
@@ -24,11 +24,9 @@ protected function getCollector(array $config = [], array $files = [], $moduleCo
2424
];
2525
$config = array_merge($config, $defaults);
2626

27-
$autoload = new \Config\Autoload();
28-
$autoload->psr4 = $config;
27+
Services::autoloader()->addNamespace($config);
2928

30-
$loader = new MockFileLocator($autoload);
31-
$loader->setFiles($files);
29+
$loader = Services::locator();
3230

3331
if ($moduleConfig === null)
3432
{

tests/system/Router/RouterTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
namespace CodeIgniter\Router;
33

4-
use Tests\Support\Autoloader\MockFileLocator;
4+
use CodeIgniter\Config\Services;
55

66
class RouterTest extends \CIUnitTestCase
77
{
@@ -24,7 +24,7 @@ public function setUp()
2424

2525
$moduleConfig = new \Config\Modules;
2626
$moduleConfig->enabled = false;
27-
$this->collection = new RouteCollection(new MockFileLocator(new \Config\Autoload()), $moduleConfig);
27+
$this->collection = new RouteCollection(Services::locator(), $moduleConfig);
2828

2929
$routes = [
3030
'users' => 'Users::index',

tests/system/View/ParserFilterTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ public function setUp()
1212
{
1313
parent::setUp();
1414

15-
$this->loader = new \CodeIgniter\Autoloader\FileLocator(new \Config\Autoload());
15+
$this->loader = \CodeIgniter\Config\Services::locator();
16+
;
1617
$this->viewsDir = __DIR__ . '/Views';
1718
$this->config = new Config\View();
1819
}

tests/system/View/ParserTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public function setUp()
1010
{
1111
parent::setUp();
1212

13-
$this->loader = new \CodeIgniter\Autoloader\FileLocator(new \Config\Autoload());
13+
$this->loader = \CodeIgniter\Config\Services::locator();
1414
$this->viewsDir = __DIR__ . '/Views';
1515
$this->config = new Config\View();
1616
}

tests/system/View/ViewTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public function setUp()
1515
{
1616
parent::setUp();
1717

18-
$this->loader = new \CodeIgniter\Autoloader\FileLocator(new \Config\Autoload());
18+
$this->loader = \CodeIgniter\Config\Services::locator();
1919
$this->viewsDir = __DIR__ . '/Views';
2020
$this->config = new Config\View();
2121
}

0 commit comments

Comments
 (0)