Merge branch 'develop' into feature/sqlite

Author: lonnieezell

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,36 @@
+---
+name: Bug report
+about: Create a report to help us improve
+
+---
+
+---
+name: Bug report
+about: Help us improve the framework by reporting bugs!
+
+---
+
+**Direction**
+We use github issues to track bugs, not for support.  
+If you have a support question, or a feature request, raise these as threads on our
+[forum](https://forum.codeigniter.com/index.php).
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**CodeIgniter 4 version**
+Which version (and branch, if applicable) the bug is in.
+
+**Affected module(s)**
+Which package or class is the bug in, if known.
+
+**Expected behavior, and steps to reproduce if appropriate**
+A clear and concise description of what you expected to happen,
+and how you got there.  
+Feel free to include a text/log extract, but use a pastebin facility for any
+screenshots you deem necessary.
+
+**Context**
+ - OS: [e.g. Windows 99]
+ - Web server [e.g. Apache 1.2.3]
+ - PHP version [e.g. 6.5.4]

.gitignore

@@ -57,6 +57,10 @@ writable/logs/*
 !writable/logs/index.html
 !writable/logs/.htaccess
 
+writable/session/*
+!writable/session/index.html
+!writable/session/.htaccess
+
 writable/uploads/*
 !writable/uploads/index.html
 !writable/uploads/.htaccess

CODE_OF_CONDUCT.md

@@ -0,0 +1,46 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at admin@codeigniter.com. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
+
+[homepage]: http://contributor-covenant.org
+[version]: http://contributor-covenant.org/version/1/4/

PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,22 @@
+Each pull request should address a single issue, and have a meaningful title.
+
+**Description**
+Explain what you have changed, and why.
+
+**Checklist:**
+- [ ] Securely signed commits
+- [ ] Component(s) with PHPdocs
+- [ ] Unit testing, with >80% coverage
+- [ ] User guide updated
+- [ ] Conforms to style guide
+
+---------Remove from here down in your description----------
+
+**Notes**
+- Pull requests must be in English
+- If the PR solves an issue, reference it with a suitable verb and the issue number
+(e.g. fixes <hash>12345
+- Unsolicited PRs will be considered, but there is no guarantee of acceptance
+- Pull requests should be from a feature branch in the contributor's fork of the repository
+  to the develop branch of the project repository
+  

application/Config/App.php

@@ -184,7 +184,7 @@ class App extends BaseConfig
 	public $sessionDriver            = 'CodeIgniter\Session\Handlers\FileHandler';
 	public $sessionCookieName        = 'ci_session';
 	public $sessionExpiration        = 7200;
-	public $sessionSavePath          = null;
+	public $sessionSavePath          = WRITEPATH . 'session';
 	public $sessionMatchIP           = false;
 	public $sessionTimeToUpdate      = 300;
 	public $sessionRegenerateDestroy = false;

application/Config/Logger.php

@@ -18,15 +18,15 @@ class Logger extends BaseConfig
 	|	2 = Alert Messages      - Action Must Be Taken Immediately
 	|   3 = Critical Messages   - Application component unavailable, unexpected exception.
 	|   4 = Runtime Errors      - Don't need immediate action, but should be monitored.
-	|   5 = Debug               - Detailed debug information.
-	|   6 = Warnings            - Exceptional occurrences that are not errors.
-	|   7 = Notices             - Normal but significant events.
-	|   8 = Info                - Interesting events, like user logging in, etc.
+	|   5 = Warnings               - Exceptional occurrences that are not errors.
+	|   6 = Notices            - Normal but significant events.
+	|   7 = Info             - Interesting events, like user logging in, etc.
+	|   8 = Debug                - Detailed debug information.
 	|   9 = All Messages
 	|
 	| You can also pass an array with threshold levels to show individual error types
 	|
-	| 	array(1, 2, 3, 5) = Emergency, Alert, Critical, and Debug messages
+	| 	array(1, 2, 3, 8) = Emergency, Alert, Critical, and Debug messages
 	|
 	| For a live site you'll usually enable Critical or higher (3) to be logged otherwise
 	| your log files will fill up very fast.

application/Config/Modules.php

@@ -0,0 +1,54 @@
+<?php namespace Config;
+
+// Cannot extend BaseConfig or looping resources occurs.
+class Modules
+{
+	/*
+	 |--------------------------------------------------------------------------
+	 | Auto-Discovery Enabled?
+	 |--------------------------------------------------------------------------
+	 |
+	 | If true, then auto-discovery will happen across all elements listed in
+	 | $activeExplorers below. If false, no auto-discovery will happen at all,
+	 | giving a slight performance boost.
+	 */
+	public $enabled = true;
+
+	/*
+	|--------------------------------------------------------------------------
+	| Auto-discover Rules
+	|--------------------------------------------------------------------------
+	|
+	| Lists the aliases of all discovery classes that will be active
+	| and used during the current application request. If it is not
+	| listed here, only the base application elements will be used.
+	*/
+	public $activeExplorers = [
+		'events',
+		'registrars',
+		'routes',
+		'services',
+	];
+
+	/**
+	 * Should the application auto-discover the requested resources.
+	 *
+	 * Valid values are:
+	 *  - events
+	 *  - registrars
+	 *  - routes
+	 *  - services
+	 *
+	 * @param string $alias
+	 *
+	 * @return bool
+	 */
+	public function shouldDiscover(string $alias)
+	{
+		if (! $this->enabled) return false;
+
+		$alias = strtolower($alias);
+
+		return in_array($alias, $this->activeExplorers);
+	}
+}

application/Config/Routes.php

@@ -64,7 +64,6 @@
 $routes->setTranslateURIDashes(false);
 $routes->set404Override();
 $routes->setAutoRoute(true);
-$routes->discoverLocal(false);
 
 /**
  * --------------------------------------------------------------------

composer.json

@@ -1,37 +1,35 @@
 {
-	"description": "The CodeIgniter framework v4",
-	"name": "codeigniter4/framework",
-	"type": "project",
-	"homepage": "https://codeigniter.com",
-	"license": "MIT",
-	"support": {
-		"forum": "http://forum.codeigniter.com/",
-		"wiki": "https://github.com/bcit-ci/CodeIgniter4/wiki",
-		"slack": "https://codeigniterchat.slack.com",
-		"source": "https://github.com/bcit-ci/CodeIgniter4"
-	},
-	"autoload": {
-		"psr-4": {
-			"CodeIgniter\\": "system/",
-			"Psr\\Log\\": "system/ThirdParty/PSR/Log/"
-		}
-	},
-	"require": {
-		"php": ">=7.1",
-		"zendframework/zend-escaper": "^2.5",
-		"paragonie/sodium_compat": "^1.1",
-              "kint-php/kint": "^2.1",
-              "ext-intl": "*"
-	},
-	"require-dev": {
-		"phpunit/phpunit": "^7.0",
-		"mikey179/vfsStream": "1.6.*",
-		"codeigniter4/codeigniter4-standard": "^1.0"
-	},
-	"scripts": {
-		"post-update-cmd": [
-			"composer dump-autoload",
-			"CodeIgniter\\ComposerScripts::postUpdate"
-		]
-	}
+    "description": "The CodeIgniter framework v4",
+    "name": "codeigniter4/framework",
+    "type": "project",
+    "homepage": "https://codeigniter.com",
+    "license": "MIT",
+    "support": {
+        "forum": "http://forum.codeigniter.com/",
+        "slack": "https://codeigniterchat.slack.com",
+        "source": "https://github.com/bcit-ci/CodeIgniter4"
+    },
+    "autoload": {
+        "psr-4": {
+            "CodeIgniter\\": "system/",
+            "Psr\\Log\\": "system/ThirdParty/PSR/Log/"
+        }
+    },
+    "require": {
+        "php": ">=7.1",
+        "zendframework/zend-escaper": "^2.5",
+        "kint-php/kint": "^2.1",
+        "ext-intl": "*"
+    },
+    "require-dev": {
+        "phpunit/phpunit": "^7.0",
+        "mikey179/vfsStream": "1.6.*",
+        "codeigniter4/codeigniter4-standard": "^1.0"
+    },
+    "scripts": {
+        "post-update-cmd": [
+            "composer dump-autoload",
+            "CodeIgniter\\ComposerScripts::postUpdate"
+        ]
+    }
 }

contributing.md

@@ -5,7 +5,7 @@
 
 We expect all contributions to conform to our style guide, be commented (inside the PHP source files), 
 be documented (in the user guide), and unit tested (in the test folder). 
-There is a [Contributing to CodeIgniter](https://bcit-ci.github.io/CodeIgniter4/contributing/index.html) section in the user guide which describes the contribution process; this page is an overview.
+There is a [Contributing to CodeIgniter](./contributing/index.rst) section in the repository which describes the contribution process; this page is an overview.
 
 ## Issues
 
@@ -35,7 +35,7 @@ If you change anything that requires a change to documentation then you will nee
 
 ### Compatibility
 
-CodeIgniter4 requires PHP 7.
+CodeIgniter4 requires PHP 7.1.
 
 ### Branching