Skip to content

Commit 228ebb5

Browse files
committed
test: extract setUp()
1 parent 554ce9e commit 228ebb5

1 file changed

Lines changed: 15 additions & 10 deletions

File tree

tests/AutoReview/ComposerJsonTest.php

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,25 +24,30 @@
2424
*/
2525
final class ComposerJsonTest extends TestCase
2626
{
27-
public function testFrameworkRequireIsTheSameWithDevRequire(): void
27+
private array $devComposer;
28+
private array $frameworkComposer;
29+
30+
protected function setUp(): void
2831
{
29-
$devComposer = $this->getComposerJson(dirname(__DIR__, 2) . '/composer.json');
30-
$frameworkComposer = $this->getComposerJson(dirname(__DIR__, 2) . '/admin/framework/composer.json');
32+
parent::setUp();
33+
34+
$this->devComposer = $this->getComposerJson(dirname(__DIR__, 2) . '/composer.json');
35+
$this->frameworkComposer = $this->getComposerJson(dirname(__DIR__, 2) . '/admin/framework/composer.json');
36+
}
3137

38+
public function testFrameworkRequireIsTheSameWithDevRequire(): void
39+
{
3240
$this->assertSame(
33-
$devComposer['require'],
34-
$frameworkComposer['require'],
41+
$this->devComposer['require'],
42+
$this->frameworkComposer['require'],
3543
'The framework\'s "require" section is not updated with the main composer.json.'
3644
);
3745
}
3846

3947
public function testFrameworkRequireDevIsTheSameWithDevRequireDev(): void
4048
{
41-
$devComposer = $this->getComposerJson(dirname(__DIR__, 2) . '/composer.json');
42-
$frameworkComposer = $this->getComposerJson(dirname(__DIR__, 2) . '/admin/framework/composer.json');
43-
44-
$devRequireDev = $devComposer['require-dev'];
45-
$fwRequireDev = $frameworkComposer['require-dev'];
49+
$devRequireDev = $this->devComposer['require-dev'];
50+
$fwRequireDev = $this->frameworkComposer['require-dev'];
4651

4752
foreach ($devRequireDev as $dependency => $expectedVersion) {
4853
if (! isset($fwRequireDev[$dependency])) {

0 commit comments

Comments
 (0)