Validation test fixes

Author: lonnieezell

php_errors.log

@@ -0,0 +1 @@
+[30-Jan-2018 23:57:36 America/Chicago] PHP Fatal error:  Class 'z' not found in /Users/kilishan/WebSites/CodeIgniter4/tests/system/Validation/RulesTest.php on line 5

tests/system/Validation/RulesTest.php

@@ -2,10 +2,8 @@
 
 use Config\Database;
 
-class RulesTest extends \CIDatabaseTestCase
+class RulesTest extends \CIUnitTestCase
 {
-	protected $refresh =true;
-
 	/**
 	 * @var Validation
 	 */
@@ -335,66 +333,6 @@ public function testDiffersFalse()
 
 	//--------------------------------------------------------------------
 
-	/**
-	 * @group DatabaseLive
-	 */
-	public function testIsUniqueFalse()
-	{
-		$data = [
-			'email' => 'derek@world.com',
-		];
-
-		$this->validation->setRules([
-			'email' => 'is_unique[user.email]',
-		]);
-
-		$this->assertFalse($this->validation->run($data));
-	}
-
-	//--------------------------------------------------------------------
-
-	/**
-	 * @group DatabaseLive
-	 */
-	public function testIsUniqueTrue()
-	{
-		$data = [
-			'email' => 'derek@world.co.uk',
-		];
-
-		$this->validation->setRules([
-			'email' => 'is_unique[user.email]',
-		]);
-
-		$this->assertTrue($this->validation->run($data));
-	}
-
-	//--------------------------------------------------------------------
-
-	/**
-	 * @group DatabaseLive
-	 */
-	public function testIsUniqueIgnoresParams()
-	{
-		$db  = Database::connect();
-		$row = $db->table('user')
-		          ->limit(1)
-		          ->get()
-		          ->getRow();
-
-		$data = [
-			'email' => 'derek@world.co.uk',
-		];
-
-		$this->validation->setRules([
-			'email' => "is_unique[user.email,id,{$row->id}]",
-		]);
-
-		$this->assertTrue($this->validation->run($data));
-	}
-
-	//--------------------------------------------------------------------
-
 	public function testMinLengthNull()
 	{
 		$data = [

tests/system/Validation/UniqueRulesTest.php

@@ -0,0 +1,110 @@
+<?php namespace CodeIgniter\Validation;
+
+use Config\Database;
+
+class UniqueRulesTest extends \CIDatabaseTestCase
+{
+	protected $refresh =true;
+
+	/**
+	 * @var Validation
+	 */
+	protected $validation;
+
+	protected $config = [
+		'ruleSets'      => [
+			\CodeIgniter\Validation\Rules::class,
+			\CodeIgniter\Validation\FormatRules::class,
+			\CodeIgniter\Validation\FileRules::class,
+			\CodeIgniter\Validation\CreditCardRules::class,
+			\CodeIgniter\Validation\TestRules::class,
+		],
+		'groupA'        => [
+			'foo' => 'required|min_length[5]',
+		],
+		'groupA_errors' => [
+			'foo' => [
+				'min_length' => 'Shame, shame. Too short.',
+			],
+		],
+	];
+
+	//--------------------------------------------------------------------
+
+	public function setUp()
+	{
+		parent::setUp();
+		$this->validation = new Validation((object)$this->config, \Config\Services::renderer());
+		$this->validation->reset();
+
+		$_FILES = [];
+	}
+
+	/**
+	 * @group DatabaseLive
+	 */
+	public function testIsUniqueFalse()
+	{
+		$this->hasInDatabase('user', [
+			'email' => 'derek@world.com'
+		]);
+
+		$data = [
+			'email' => 'derek@world.com',
+		];
+
+		$this->validation->setRules([
+			'email' => 'is_unique[user.email]',
+		]);
+
+		$this->assertFalse($this->validation->run($data));
+	}
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * @group DatabaseLive
+	 */
+	public function testIsUniqueTrue()
+	{
+		$data = [
+			'email' => 'derek@world.co.uk',
+		];
+
+		$this->validation->setRules([
+			'email' => 'is_unique[user.email]',
+		]);
+
+		$this->assertTrue($this->validation->run($data));
+	}
+
+	//--------------------------------------------------------------------
+
+	/**
+	 * @group DatabaseLive
+	 */
+	public function testIsUniqueIgnoresParams()
+	{
+		$this->hasInDatabase('user', [
+			'email' => 'derek@world.co.uk'
+		]);
+
+		$db  = Database::connect();
+		$row = $db->table('user')
+		          ->limit(1)
+		          ->get()
+		          ->getRow();
+
+		$data = [
+			'email' => 'derek@world.co.uk',
+		];
+
+		$this->validation->setRules([
+			'email' => "is_unique[user.email,id,{$row->id}]",
+		]);
+
+		$this->assertTrue($this->validation->run($data));
+	}
+
+	//--------------------------------------------------------------------
+}