optional reset in countAll (as is in countAllResults)

nowackipawel · web-flow · commit 19b13b9ecbe1 · 2018-09-13T16:50:43.000+02:00
required changes in test file
fix: countAllResults call
diff --git a/tests/system/Database/Builder/CountTest.php b/tests/system/Database/Builder/CountTest.php
@@ -24,7 +24,7 @@ public function testCountAll()
 
 		$expectedSQL   = "SELECT COUNT(*) AS \"numrows\" FROM \"jobs\"";
 
-		$this->assertEquals($expectedSQL, $builder->countAll(true));
+		$this->assertEquals($expectedSQL, $builder->countAll(true, true));
 	}
 
 	//--------------------------------------------------------------------
@@ -33,7 +33,7 @@ public function testCountAllResults()
 	{
 		$builder = new BaseBuilder('jobs', $this->db);
 
-		$answer = $builder->where('id >', 3)->countAllResults(null, true);
+		$answer = $builder->where('id >', 3)->countAllResults(false, true);
 
 		$expectedSQL   = "SELECT COUNT(*) AS \"numrows\" FROM \"jobs\" WHERE \"id\" > :id:";
 

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public function testCountAll()`
`24`	`24`
`25`	`25`	`$expectedSQL = "SELECT COUNT(*) AS \"numrows\" FROM \"jobs\"";`
`26`	`26`
`27`		`- $this->assertEquals($expectedSQL, $builder->countAll(true));`
	`27`	`+ $this->assertEquals($expectedSQL, $builder->countAll(true, true));`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`//--------------------------------------------------------------------`
`@@ -33,7 +33,7 @@ public function testCountAllResults()`
`33`	`33`	`{`
`34`	`34`	`$builder = new BaseBuilder('jobs', $this->db);`
`35`	`35`
`36`		`- $answer = $builder->where('id >', 3)->countAllResults(null, true);`
	`36`	`+ $answer = $builder->where('id >', 3)->countAllResults(false, true);`
`37`	`37`
`38`	`38`	`$expectedSQL = "SELECT COUNT(*) AS \"numrows\" FROM \"jobs\" WHERE \"id\" > :id:";`
`39`	`39`