Remove pointless check from conditional

dafriend · dafriend · commit 146cbec20b27 · 2019-11-14T08:52:11.000-06:00
Because the argument $index has a type declaration of 'array' there is no point in using is_array($index) in the conditional.
diff --git a/system/HTTP/Files/FileCollection.php b/system/HTTP/Files/FileCollection.php
@@ -310,7 +310,7 @@ protected function fixFilesArray(array $data): array
 	 */
 	protected function getValueDotNotationSyntax(array $index, array $value)
 	{
-		if (is_array($index) && ! empty($index))
+		if (! empty($index))
 		{
 			$current_index = array_shift($index);
 		}

Original file line number	Diff line number	Diff line change
`@@ -310,7 +310,7 @@ protected function fixFilesArray(array $data): array`
`310`	`310`	`*/`
`311`	`311`	`protected function getValueDotNotationSyntax(array $index, array $value)`
`312`	`312`	`{`
`313`		`- if (is_array($index) && ! empty($index))`
	`313`	`+ if (! empty($index))`
`314`	`314`	`{`
`315`	`315`	`$current_index = array_shift($index);`
`316`	`316`	`}`