Complete CURLRequest testing & update its UG page

Author: jim-parry

system/HTTP/CURLRequest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CodeIgniter\HTTP;
 
 /**
@@ -72,10 +73,10 @@ class CURLRequest extends Request
 	 * @var array
 	 */
 	protected $config = [
-		'timeout'			 => 0.0,
-		'connect_timeout'	 => 150,
-		'debug'				 => false,
-		'verify'			 => true
+		'timeout' => 0.0,
+		'connect_timeout' => 150,
+		'debug' => false,
+		'verify' => true
 	];
 
 	/**
@@ -85,9 +86,9 @@ class CURLRequest extends Request
 	 * @var array
 	 */
 	protected $redirectDefaults = [
-		'max'		 => 5,
-		'strict'	 => true,
-		'protocols'	 => ['http', 'https'],
+		'max' => 5,
+		'strict' => true,
+		'protocols' => ['http', 'https'],
 	];
 
 	/**

system/HTTP/Exceptions/HTTPException.php

@@ -11,6 +11,9 @@ class HTTPException extends FrameworkException implements ExceptionInterface
 	 * For CurlRequest
 	 *
 	 * @return \CodeIgniter\HTTP\Exceptions\HTTPException
+	 * 
+	 * Not testable with travis-ci
+	 * @codeCoverageIgnore		
 	 */
 	public static function forMissingCurl()
 	{
@@ -48,6 +51,9 @@ public static function forInvalidSSLKey(string $key)
 	 * @param string $error
 	 *
 	 * @return \CodeIgniter\HTTP\Exceptions\HTTPException
+	 * 
+	 * Not testable with travis-ci; we over-ride the method which triggers it
+	 * @codeCoverageIgnore		
 	 */
 	public static function forCurlError(string $errorNum, string $error)
 	{

tests/_support/HTTP/Files/CookiesHolder.txt

@@ -0,0 +1 @@
+

tests/_support/HTTP/MockCURLRequest.php

@@ -1,4 +1,6 @@
-<?php namespace Tests\Support\HTTP;
+<?php
+
+namespace Tests\Support\HTTP;
 
 use CodeIgniter\HTTP\CURLRequest;
 
@@ -11,8 +13,8 @@
  */
 class MockCURLRequest extends CURLRequest
 {
-	public $curl_options;
 
+	public $curl_options;
 	protected $output = '';
 
 	//--------------------------------------------------------------------
@@ -35,5 +37,16 @@ protected function sendRequest(array $curl_options = []): string
 	}
 
 	//--------------------------------------------------------------------
+	// for testing purposes only
+	public function getBaseURI()
+	{
+		return $this->baseURI;
+	}
+
+	// for testing purposes only
+	public function getDelay()
+	{
+		return $this->delay;
+	}
 
 }