Fix missed application/ folder references

Author: jim-parry

contributing/internals.rst

@@ -88,7 +88,7 @@ Configuration
 =============
 
 Should the package require user-configurable settings, you should create a new file just for that package under
-**application/Config**. The file name should generally match the package name.
+**app/Config**. The file name should generally match the package name.
 
 Autoloader
 ==========

system/Autoloader/Autoloader.php

@@ -310,8 +310,8 @@ protected function loadInNamespace(string $class)
 
 	/**
 	 * Attempts to load the class from common locations in previous
-	 * version of CodeIgniter, namely 'application/libraries', and
-	 * 'application/Models'.
+	 * version of CodeIgniter, namely 'app/Libraries', and
+	 * 'app/Models'.
 	 *
 	 * @param string $class The class name. This typically should NOT have a namespace.
 	 *

system/Autoloader/FileLocator.php

@@ -202,8 +202,8 @@ public function getClassname(string $file) : string
 	 *  $locator->search('Config/Routes.php');
 	 *  // Assuming PSR4 namespaces include foo and bar, might return:
 	 *  [
-	 *      'application/modules/foo/Config/Routes.php',
-	 *      'application/modules/bar/Config/Routes.php',
+	 *      'app/Modules/foo/Config/Routes.php',
+	 *      'app/Modules/bar/Config/Routes.php',
 	 *  ]
 	 *
 	 * @param string $path

system/Common.php

@@ -569,7 +569,7 @@ function remove_invisible_characters($str, $url_encoded = true)
 	 * both in and out of the 'helpers' directory of a namespaced directory.
 	 *
 	 * Will load ALL helpers of the matching name, in the following order:
-	 *   1. application/Helpers
+	 *   1. app/Helpers
 	 *   2. {namespace}/Helpers
 	 *   3. system/Helpers
 	 *

system/Log/Logger.php

@@ -511,7 +511,7 @@ public function determineFile()
 	 * Cleans the paths of filenames by replacing APPPATH, SYSTEMPATH, FCPATH
 	 * with the actual var. i.e.
 	 *
-	 *  /var/www/site/application/Controllers/Home.php
+	 *  /var/www/site/app/Controllers/Home.php
 	 *      becomes:
 	 *  APPPATH/Controllers/Home.php
 	 *

system/Router/RouteCollection.php

@@ -1308,7 +1308,7 @@ protected function create(string $verb, string $from, $to, array $options = null
 		$name = $options['as'] ?? $from;
 
 		// Don't overwrite any existing 'froms' so that auto-discovered routes
-		// do not overwrite any application/Config/Routes settings. The app
+		// do not overwrite any app/Config/Routes settings. The app
 		// routes should always be the "source of truth".
 		// this works only because discovered routes are added just prior
 		// to attempting to route the request.

system/Session/Session.php

@@ -42,7 +42,7 @@
  * Implementation of CodeIgniter session container.
  *
  * Session configuration is done through session variables and cookie related
- * variables in application/config/App.php
+ * variables in app/config/App.php
  */
 class Session implements SessionInterface
 {

tests/README.md

@@ -14,7 +14,7 @@ If running under OS X or Linux, you will want to create a symbolic link to make
 
 ## Setup
 
-A number of the tests that are ran during the test suite are ran against a running database. In order to setup the database used here, edit the details for the `tests` database group in **application/Config/Database.php**. Make sure that you provide a database engine that is currently running, and have already created a table that you can use only for these tests, as it will be wiped and refreshed often while running the test suite.  
+A number of the tests that are ran during the test suite are ran against a running database. In order to setup the database used here, edit the details for the `tests` database group in **app/Config/Database.php**. Make sure that you provide a database engine that is currently running, and have already created a table that you can use only for these tests, as it will be wiped and refreshed often while running the test suite.  
 
 If you want to run the tests without running the live database tests, you can exclude @DatabaseLive group. Or make a copy of **phpunit.dist.xml**, call it **phpunit.xml**, and un-comment the line within the testsuite that excludes the **tests/system/Database/Live** directory. This will make the tests run quite a bit faster.
 

user_guide_src/source/changelogs/v4.0.0-alpha.3.rst

@@ -307,7 +307,7 @@ PRs merged:
 - #1460 remove unneeded ternary check at HoneyPot
 - #1457 use $paths->systemDirectory in public/index.php 
 - #1456 Beef up HTTP URI & Response testing
-- #1455 un-ignore application/Database/Migrations directory
+- #1455 un-ignore app/Database/Migrations directory
 - #1454 add missing break; in loop at Email::getEncoding()
 - #1453 BugFix if there extension has only one mime type
 - #1451 remove unneeded $session->start(); check on RedirectResponse
@@ -318,7 +318,7 @@ PRs merged:
 - #1445 using existing is_cli() function in HTTP\IncomingRequest
 - #1444 Dox for reorganized repo admin (4 of 4)
 - #1443 Fixes unit test output not captured
-- #1442 remove form view in application/View/ and form helper usage in create new items tutorial
+- #1442 remove form view in app/View/ and form helper usage in create new items tutorial
 - #1440 Access to model's last inserted ID
 - #1438 Tailor the last few repo org names (3 of 4)
 - #1437 Replace repo org name in MOST php docs (2 of 4)

user_guide_src/source/helpers/text_helper.rst

@@ -263,7 +263,7 @@ The following functions are available:
 		$string = convert_accented_characters($string);
 
 	.. note:: This function uses a companion config file
-		`application/Config/ForeignCharacters.php` to define the to and
+		`app/Config/ForeignCharacters.php` to define the to and
 		from array for transliteration.
 
 .. php:function:: word_censor($str, $censored[, $replacement = ''])