From 4440e20fd0d68d439c5f7dfe6d824ee888cd9186 Mon Sep 17 00:00:00 2001 From: "sentry[bot]" <39604003+sentry[bot]@users.noreply.github.com> Date: Sun, 27 Sep 2026 10:46:33 +0000 Subject: [PATCH] fix: Prevent TypeError from caching API error responses --- src/content/github/common/fetchers.ts | 6 ++++-- src/service.ts | 8 ++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/content/github/common/fetchers.ts b/src/content/github/common/fetchers.ts index 8807c29..7f20414 100644 --- a/src/content/github/common/fetchers.ts +++ b/src/content/github/common/fetchers.ts @@ -18,7 +18,8 @@ export async function getFlags(metadata: FileMetadata): Promise { referrer: window.location.href, }); - const flags = response.ok ? response.data.results : []; + const results = response.ok ? response.data.results : []; + const flags = Array.isArray(results) ? results : []; return flags.map((f: any) => f.flag_name); } @@ -35,7 +36,8 @@ export async function getComponents(metadata: FileMetadata): Promise { referrer: window.location.href, }); - const components = response.ok ? response.data : []; + const data = response.ok ? response.data : []; + const components = Array.isArray(data) ? data : []; return components.map((c: any) => c.component_id); } diff --git a/src/service.ts b/src/service.ts index d347127..a30c586 100644 --- a/src/service.ts +++ b/src/service.ts @@ -213,7 +213,9 @@ export class Codecov { }); const data = await response.json(); - await this.setCached("flags", owner, repo, data); + if (response.ok) { + await this.setCached("flags", owner, repo, data); + } return { ok: response.ok, @@ -246,7 +248,9 @@ export class Codecov { }); const data = await response.json(); - await this.setCached("components", owner, repo, data); + if (response.ok) { + await this.setCached("components", owner, repo, data); + } return { ok: response.ok,