refactor: remove logic

Author: John Doe

e2e/nx-plugin-e2e/tests/executor-cli.e2e.test.ts

@@ -27,17 +27,21 @@ async function addTargetToWorkspace(
 ) {
   const { cwd, project } = options;
   const projectCfg = readProjectConfiguration(tree, project);
+  const { root } = projectCfg;
+  const configPath = path.join(root, 'code-pushup.config.ts');
   updateProjectConfiguration(tree, project, {
     ...projectCfg,
     targets: {
       ...projectCfg.targets,
       'code-pushup': {
         executor: '@code-pushup/nx-plugin:cli',
-        ...(executorOptions && { options: executorOptions }),
+        options: {
+          config: configPath,
+          ...executorOptions,
+        },
       },
     },
   });
-  const { root } = projectCfg;
   generateCodePushupConfig(tree, root, {
     plugins: [
       {

packages/nx-plugin/src/executors/cli/utils.ts

@@ -54,41 +54,3 @@ export function parseAutorunExecutorOptions(
     ...(needsUploadParams && hasApiToken ? { upload: uploadCfg } : {}),
   };
 }
-
-/**
- * Deeply merges executor options.
- *
- * @param targetOptions - The original options from the target configuration.
- * @param cliOptions - The options from Nx, combining target options and CLI arguments.
- * @returns A new object with deeply merged properties.
- *
- * Nx performs a shallow merge by default, where command-line arguments can override entire objects
- * (e.g., `--persist.filename` replaces the entire `persist` object).
- * This function ensures that nested properties are deeply merged,
- * preserving the original target options where CLI arguments are not provided.
- */
-export function mergeExecutorOptions(
-  targetOptions: Partial<AutorunCommandExecutorOptions>,
-  cliOptions: Partial<AutorunCommandExecutorOptions>,
-): AutorunCommandExecutorOptions {
-  return {
-    ...targetOptions,
-    ...cliOptions,
-    ...(targetOptions?.persist || cliOptions?.persist
-      ? {
-          persist: {
-            ...targetOptions?.persist,
-            ...cliOptions?.persist,
-          },
-        }
-      : {}),
-    ...(targetOptions?.upload || cliOptions?.upload
-      ? {
-          upload: {
-            ...targetOptions?.upload,
-            ...cliOptions?.upload,
-          },
-        }
-      : {}),
-  };
-}

packages/nx-plugin/src/executors/cli/utils.unit.test.ts

@@ -170,26 +170,3 @@ describe('parseAutorunExecutorOptions', () => {
     },
   );
 });
-
-describe('mergeExecutorOptions', () => {
-  it('should deeply merge target and CLI options', () => {
-    const targetOptions = {
-      persist: {
-        outputDir: '.reports',
-        filename: 'report',
-      },
-    };
-    const cliOptions = {
-      persist: {
-        filename: 'report-file',
-      },
-    };
-    const expected = {
-      persist: {
-        outputDir: '.reports',
-        filename: 'report-file',
-      },
-    };
-    expect(mergeExecutorOptions(targetOptions, cliOptions)).toEqual(expected);
-  });
-});