Change from Ignore to Include sync flag (minor change)

Author: arielien

Command/DownloadImages.php

@@ -21,14 +21,14 @@ class DownloadImages extends Command
     const OVERRIDE = 'override';
     const FORCE = 'force';
     const ENV = 'env';
-    const IGNORE_SYNC = 'ignore-synchronization';
+    const INCLUDE_SYNC = 'include-synchronization';
     /**#@- */
 
     const OVERRIDE_CONFIRM_MESSAGE = "<question>Are you sure you want to override local files (y/n)[n]?</question>";
 
     private $_override = false;
 
-    private $_ignoreSync = false;
+    private $_includeSync = false;
 
     /**
      * @var ObjectManagerInterface
@@ -76,7 +76,7 @@ public function __construct(
     protected function configure()
     {
         $this->setName('cloudinary:download:all');
-        $this->setDescription('Download images from Cloudinary to the local pub/media dir. Optionally, ignore synchronization state and download everything');
+        $this->setDescription('Download images from Cloudinary to the local pub/media dir. Optionally, Include synchronization state and download everything');
         $this->setDefinition([
             new InputOption(
                 self::OVERRIDE,
@@ -98,10 +98,10 @@ protected function configure()
                 null
             ),
             new InputOption(
-                self::IGNORE_SYNC,
+                self::INCLUDE_SYNC,
                 '-i',
                 InputOption::VALUE_NONE,
-                'Ignore synchronization state and download all images',
+                'Include synchronization state and download all images',
             )
         ]);
     }
@@ -128,11 +128,11 @@ protected function execute(InputInterface $input, OutputInterface $output)
             if ($input->getOption(self::FORCE)) {
                 $this->coreRegistry->register(Configuration::CONFIG_PATH_ENABLED, true);
             }
-            if ($input->getOption(self::IGNORE_SYNC)) {
-                $this->_ignoreSync = true;
+            if ($input->getOption(self::INCLUDE_SYNC)) {
+                $this->_includeSync = true;
             }
             $this->outputLogger->setOutput($output);
-            $this->batchDownloader->downloadUnsynchronisedImages($this->outputLogger, $this->_override, $this->_ignoreSync);
+            $this->batchDownloader->downloadUnsynchronisedImages($this->outputLogger, $this->_override, $this->_includeSync);
 
             return 1;
 

Model/BatchDownloader.php

@@ -178,7 +178,7 @@ private function _authorise()
      * @return bool
      * @throws \Exception
      */
-    public function downloadUnsynchronisedImages(?OutputInterface $output = null, $override = false, $ignoreSync = false)
+    public function downloadUnsynchronisedImages(?OutputInterface $output = null, $override = false, $includeSync = false)
     {
         if (!$this->_configuration->isEnabled(false)) {
             throw new \Exception("Cloudinary seems to be disabled. Please enable it first or pass -f in order to force it on the CLI");
@@ -195,8 +195,8 @@ public function downloadUnsynchronisedImages(?OutputInterface $output = null, $o
         $baseMediaPath = $this->_directoryList->getPath(DirectoryList::MEDIA);
         $directoryInstance = $this->_fileSystem->getDirectoryWrite(DirectoryList::MEDIA);
 
-        if ($ignoreSync) {
-            $this->displayMessage('<comment>== [Notice] == Process started with ignore-synchronization flag.</comment>');
+        if ($includeSync) {
+            $this->displayMessage('<comment>== [Notice] == Process started with include-synchronization flag.</comment>');
         }
 
         //= Checking migration lock / Start migration
@@ -269,7 +269,7 @@ public function downloadUnsynchronisedImages(?OutputInterface $output = null, $o
 
                             //Flagging as syncronized
                             $resource->setImage(Image::fromPath($localFilePath, $localFileName));
-                            if ($ignoreSync || $resource->getImage()->getRelativePath() && !$this->_synchronizationChecker->isSynchronized($resource->getImage()->getRelativePath())) {
+                            if ($includeSync || $resource->getImage()->getRelativePath() && !$this->_synchronizationChecker->isSynchronized($resource->getImage()->getRelativePath())) {
                                 $this->displayMessage('<comment>=== [Processing] Flagging As Syncronized...</comment>');
                                 $this->_synchronisationRepository->saveAsSynchronized($resource->getImage()->getRelativePath());
                             } else {