From 52e0593a1d14bb88cca6df925c26c0399c4ea0da Mon Sep 17 00:00:00 2001 From: Christos Miniotis Date: Tue, 16 Jun 2026 02:55:52 +0300 Subject: [PATCH] Rename file sharing label to SMB network shares --- docs/dashboard.md | 2 +- docs/drive_health.md | 2 +- docs/network_file_sharing.md | 8 ++++---- index.html | 2 +- templates/base.html | 2 +- templates/dashboard.html | 6 +++--- templates/network_file_sharing.html | 4 ++-- tests/test_app_factory_routes.py | 3 +++ tests/test_drive_health_docs.py | 4 ++-- 9 files changed, 18 insertions(+), 15 deletions(-) diff --git a/docs/dashboard.md b/docs/dashboard.md index 10df2bb..450eaea 100644 --- a/docs/dashboard.md +++ b/docs/dashboard.md @@ -5,7 +5,7 @@ The Dashboard is the main interface for monitoring and managing the system. It p ## Status Indicators Four cards display real-time status: - **Storage**: Shows drive connection status, used/total storage, and usage percentage. -- **Network File Sharing**: Summarizes `smbd`, `nmbd`, and `wsdd2`. The tile is operational when +- **SMB Network Shares**: Summarizes `smbd`, `nmbd`, and `wsdd2`. The tile is operational when `smbd` is active and discovery services are either active or unavailable (not installed), partial when `smbd` is active but at least one discovery service is inactive, and down when `smbd` is not active. diff --git a/docs/drive_health.md b/docs/drive_health.md index 9d9018f..9bf7bd7 100644 --- a/docs/drive_health.md +++ b/docs/drive_health.md @@ -138,7 +138,7 @@ Manual recovery rules: - Update only the SimpleSaferServer-managed `/etc/fstab` entry. - Use `ntfs-3g` or `ntfs3` as the filesystem type for the managed backup-drive line. - Run `sudo systemctl daemon-reload` after manually changing `/etc/fstab` so systemd forgets the old generated mount unit state. -- If the mount point changes, also check `/etc/samba/simple_safer_server_shares.conf` (see [Network File Sharing](network_file_sharing.md)). +- If the mount point changes, also check `/etc/samba/simple_safer_server_shares.conf` (see [SMB Network Shares](network_file_sharing.md)). - Do not modify unrelated `/etc/fstab` entries. - Back up `/etc/fstab` before editing it manually. diff --git a/docs/network_file_sharing.md b/docs/network_file_sharing.md index f1abc71..8b9255c 100644 --- a/docs/network_file_sharing.md +++ b/docs/network_file_sharing.md @@ -1,6 +1,6 @@ -# Network File Sharing +# SMB Network Shares -The Network File Sharing page manages Samba shares and Samba service status. +The SMB Network Shares page manages Samba shares and Samba service status. It also includes the server name. This is the name you'll use to find this server on your network. Scheduled task alert emails include it in the subject. @@ -175,7 +175,7 @@ If the share depends on unsupported Samba directives, leave it unmanaged and mai 3. Remove it from the unmanaged config source and add it to `/etc/samba/simple_safer_server_shares.conf`. 4. Keep only the supported share settings. 5. Restart Samba. -6. Reload the Network File Sharing page and confirm the share appears in the managed table. +6. Reload the SMB Network Shares page and confirm the share appears in the managed table. ### Example @@ -209,7 +209,7 @@ Restarting Samba disconnects anyone who is currently connected to a share, so ac sudo systemctl restart smbd nmbd wsdd2 ``` -Reload the Network File Sharing page after that. +Reload the SMB Network Shares page after that. ## Setup Wizard Behavior diff --git a/index.html b/index.html index 538ee2f..8b5f824 100644 --- a/index.html +++ b/index.html @@ -165,7 +165,7 @@

Documentati
  • Cloud Backup
  • System Updates
  • Dynamic DNS
    • -
  • Network File Sharing
    • +
  • SMB Network Shares
  • Users
  • Alerts
  • Task Details
    • diff --git a/templates/base.html b/templates/base.html index e60dc9d..3426544 100644 --- a/templates/base.html +++ b/templates/base.html @@ -50,7 +50,7 @@ Overview - File Sharing + SMB Network Shares Users diff --git a/templates/dashboard.html b/templates/dashboard.html index 2fa14df..5047b13 100644 --- a/templates/dashboard.html +++ b/templates/dashboard.html @@ -48,10 +48,10 @@
    —
    - +
    - File Sharing + SMB Network Shares Checking…
    —
    @@ -729,7 +729,7 @@

    System Actions

    badge.textContent = 'Partial'; val.textContent = 'Degraded'; // Keep the compact detail explicit so the dashboard matches the - // File Sharing page without adding another explanatory panel. + // SMB Network Shares page without adding another explanatory panel. detail.textContent = `smbd: ${data.smbd}, nmbd: ${data.nmbd}, wsdd2: ${data.wsdd2}`; } else { badge.className = 'badge badge-danger'; diff --git a/templates/network_file_sharing.html b/templates/network_file_sharing.html index e7f282a..e2aa465 100644 --- a/templates/network_file_sharing.html +++ b/templates/network_file_sharing.html @@ -1,7 +1,7 @@ {% extends "base.html" %} -{% block title %}{{ browser_title('File Sharing') }}{% endblock %} -{% block header %}Network File Sharing{% endblock %} +{% block title %}{{ browser_title('SMB Network Shares') }}{% endblock %} +{% block header %}SMB Network Shares{% endblock %} {% block extra_css %} {% endblock %} diff --git a/tests/test_app_factory_routes.py b/tests/test_app_factory_routes.py index b8b568e..48891ab 100644 --- a/tests/test_app_factory_routes.py +++ b/tests/test_app_factory_routes.py @@ -57,6 +57,7 @@ def test_fake_dashboard_renders_storage_action_urls(): assert "Unavailable / Unavailable GB used" not in page assert 'action="/unmount"' in page assert 'action="/mount"' in page + assert "SMB Network Shares" in page assert 'id="health-refresh-button"' in page assert "Next Run" in page assert "Disable Schedule" in page @@ -81,6 +82,8 @@ def test_network_file_sharing_renders_three_service_status_labels_and_help_text( assert response.status_code == 200 page = response.get_data(as_text=True) + assert "SMB Network Shares" in page + assert "Network File Sharing" not in page assert "SMB Daemon (smbd)" in page assert "NetBIOS Discovery (nmbd)" in page assert "Windows Discovery (wsdd2)" in page diff --git a/tests/test_drive_health_docs.py b/tests/test_drive_health_docs.py index e617067..c659449 100644 --- a/tests/test_drive_health_docs.py +++ b/tests/test_drive_health_docs.py @@ -25,8 +25,8 @@ def test_manual_recovery_references_sss_shares_file(): def test_manual_recovery_references_network_file_sharing_page(): section = _manual_recovery_section() - # Should point operators to the Network File Sharing docs page - assert "network_file_sharing" in section.lower() or "Network File Sharing" in section + # Should point operators to the SMB Network Shares docs page + assert "network_file_sharing" in section.lower() or "SMB Network Shares" in section def test_manual_recovery_does_not_present_smb_conf_as_managed_share_config():